Skip to content

feat: Support Remote Desktop token persistance - #8865

Merged
nbolton merged 1 commit into
masterfrom
PersistRemoteDesktop
Aug 19, 2025
Merged

feat: Support Remote Desktop token persistance#8865
nbolton merged 1 commit into
masterfrom
PersistRemoteDesktop

Conversation

@sithlord48

@sithlord48 sithlord48 commented Aug 18, 2025

Copy link
Copy Markdown
Member

Fixes #8869 for Remote Desktop (i.e client)

IMHO There is no reason to ever allow input capture always (i.e server).

Besides, When / If The Input Capture portal gains support for a restore token it should be trivial to use this PR as an example enabling it for that portal.

Edit by @nbolton: Thanks to @whot for work upstream which made this possible.

@sithlord48
sithlord48 requested a review from nbolton August 18, 2025 14:25
@sithlord48 sithlord48 added wayland This issues effects Wayland on Linux 🩹 fix This PR fixes a reported bug labels Aug 18, 2025
@sithlord48 sithlord48 added this to the v1.24.0 milestone Aug 18, 2025
@sithlord48
sithlord48 force-pushed the PersistRemoteDesktop branch from 8607fb9 to 39958f5 Compare August 18, 2025 14:30
@sithlord48 sithlord48 added ✨ enhancement A suggested change to improve functionality 💎 bounty 🪄 feature request This PR adds a requested feature and removed 💎 bounty labels Aug 18, 2025
@sithlord48
sithlord48 force-pushed the PersistRemoteDesktop branch 3 times, most recently from 4dd5b27 to 9b86406 Compare August 18, 2025 15:22
@sithlord48
sithlord48 force-pushed the PersistRemoteDesktop branch from 9b86406 to b4b700f Compare August 18, 2025 20:33
@nbolton

nbolton commented Aug 19, 2025

Copy link
Copy Markdown
Member

I'm looking forward to using this feature!

I get an error on Arch+KDE: [2025-08-19T09:35:03] ERROR: failed to initialize remote desktop session: GDBus.Error:org.freedesktop.portal.Error.InvalidArgument: Restore token is not a valid UUID string

Edit: Seems to work on GNOME though, amazing! I wonder... how do I un-remember the decision?

Screenshot From 2025-08-19 09-53-04

@sithlord48

sithlord48 commented Aug 19, 2025

Copy link
Copy Markdown
Member Author

Um to remove remember involves using the desktop to clear it. The easiest way is to (for now) is to remove the xdgRestoreToken entry from the client section of the settings file.

Ill maybe add a setting to clear it in our gui. But this is something your desktop should provide a settings area for like the kde flatpak permission kcm.

Odd as its fine on my kde machine the restore key (in settings) should be a uuid .. did you use the QtPortals branch on that machine that branch write a non UUID token for the same value (if so just clear it out)

@nbolton
nbolton merged commit b2aa638 into master Aug 19, 2025
31 checks passed
@nbolton
nbolton deleted the PersistRemoteDesktop branch August 19, 2025 14:46
@nbolton

nbolton commented Aug 19, 2025

Copy link
Copy Markdown
Member

did you use the QtPortals branch on that machine that branch write a non UUID token for the same value (if so just clear it out)

Turns out I had a borked libportal.so, reinstalling fixed it: sudo pacman -S xdg-desktop-portal

Um to remove remember involves using the desktop to clear it. The easiest way is to (for now) is to remove the xdgRestoreToken entry from the client section of the settings file.

Yes, this clears it. I edited /home/nick/.config/Deskflow/Deskflow.conf and removed the xdpRestoreToken= line.

Ill maybe add a setting to clear it in our gui.

I think manually editing the .conf is good enough, but maybe we should document that at least?

@sithlord48

Copy link
Copy Markdown
Member Author

I think manually editing the .conf is good enough, but maybe we should document that at least?

Added to https://github.com/deskflow/deskflow/wiki/Workarounds#Remove-Xdg-Remote-Desktop-permission

@whot

whot commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

IMHO There is no reason to ever allow input capture always (i.e server).

depends on your setting but either way xdg-desktop-portal#1768 would address that.

That's an orthogonal problem to the token persistence though (token persistence is also used for "allow reconnect" after a previous ack, for some value of "after". As opposed to "allow unquestioned connect", two subtly different problems).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ enhancement A suggested change to improve functionality 🪄 feature request This PR adds a requested feature 🩹 fix This PR fixes a reported bug wayland This issues effects Wayland on Linux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Persist Remote Desktop XDG Desktop Portal dialog (Wayland)

3 participants