feat: Use xkb_keymap_mod_get_mask in EiKeyState if available - #8860
Merged
Conversation
nbolton
marked this pull request as draft
August 14, 2025 21:37
nbolton
commented
Aug 14, 2025
sithlord48
reviewed
Aug 14, 2025
sithlord48
reviewed
Aug 14, 2025
sithlord48
reviewed
Aug 14, 2025
12 tasks
nbolton
force-pushed
the
xkbcommon-get-mask
branch
5 times, most recently
from
August 22, 2025 11:26
0ae8075 to
81fede2
Compare
nbolton
commented
Aug 22, 2025
nbolton
force-pushed
the
xkbcommon-get-mask
branch
2 times, most recently
from
August 22, 2025 12:22
5a53553 to
ced4186
Compare
nbolton
commented
Aug 22, 2025
nbolton
force-pushed
the
xkbcommon-get-mask
branch
3 times, most recently
from
August 22, 2025 13:14
90d3192 to
123ba12
Compare
nbolton
marked this pull request as ready for review
August 22, 2025 13:21
nbolton
commented
Aug 22, 2025
sithlord48
reviewed
Aug 22, 2025
nbolton
marked this pull request as draft
August 22, 2025 13:39
nbolton
force-pushed
the
xkbcommon-get-mask
branch
from
August 22, 2025 13:39
123ba12 to
497dc85
Compare
This comment was marked as outdated.
This comment was marked as outdated.
nbolton
force-pushed
the
xkbcommon-get-mask
branch
from
August 22, 2025 13:54
497dc85 to
766b4b0
Compare
nbolton
marked this pull request as ready for review
August 22, 2025 13:55
Introduced in xkbcommon v1.10.0
nbolton
force-pushed
the
xkbcommon-get-mask
branch
from
August 22, 2025 14:01
766b4b0 to
d065913
Compare
sithlord48
approved these changes
Aug 22, 2025
sithlord48
left a comment
sithlord48
left a comment
Member
There was a problem hiding this comment.
This seams to make All my modifiers work correctly on kde wayland client (with xkbcommon 1.11)
There is still the issue of numlock or caps lock is not in sync with the client in all cases but this is also an issue elsewhere tool.
Member
Author
This PR did not fix my modifiers for some reason... I had to open #8881 for that. |
This was referenced Aug 22, 2025
wismill
reviewed
Aug 25, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8833
Uses
xkb_keymap_mod_get_maskintroduced in xkbcommon v1.10.0This simply replaces:
if ((xkbMask & (1 << xkbMod)) == 0)It does not intentionally change the modifier behavior. Therefore, it doesn't intentionally fix these issues:
Ctrl+Altinstead of special characters #8864However, the
convertModMaskfunction may be related to those bugs, and so this may have some sort of impact.Related PRs that may also change modifier behavior on Wayland/EI:
CC @wismill @whot