Skip to content

fix: resolve issues with some swedish characters - #8856

Merged
sithlord48 merged 1 commit into
masterfrom
betterKeyMapParse
Aug 14, 2025
Merged

fix: resolve issues with some swedish characters#8856
sithlord48 merged 1 commit into
masterfrom
betterKeyMapParse

Conversation

@sithlord48

@sithlord48 sithlord48 commented Aug 13, 2025

Copy link
Copy Markdown
Member

Partly solves: #8839

@nbolton

nbolton commented Aug 13, 2025

Copy link
Copy Markdown
Member

@sithlord48 Nice. Do you have some good repro steps so I can see the bug happening on master? Do I need to switch to non-English layout?

@sithlord48

sithlord48 commented Aug 13, 2025

Copy link
Copy Markdown
Member Author

You will need to use a non US layout and try to send @ or | using the 3rd layer compositing.
And i am unsure if the client or server is the one that messed up here.
@tnn2 might be able to provide more info on what you should be trying.

@nbolton

nbolton commented Aug 14, 2025

Copy link
Copy Markdown
Member

And i am unsure if the client or server is the one that messed up here.

Maybe client? But I'll try both.

@nbolton

nbolton commented Aug 14, 2025

Copy link
Copy Markdown
Member

I don't think this fixes the original bug reported in #8839 (which I originally tagged as a Wayland issue). I'm happy for #8839 to be repurposed as the X11 bug that @tnn2 is seeing. The original issue was for a Synergy 1.18 user which was long before a33574e so I'll simply clone #8839 to a new issue which is Wayland specific as before.

With Wayland client, on both master and this PR, with a French layout on the client, the number row is quite messed up; it's all opposite.

  • When pressing Shift+0 I get: 0
  • When pressing 0 I get: à

Whether or not I choose 'Use server language' in preferences, it makes no difference to the behavior. I tried all combinations of server/client layout and it seems to only apply to the client.

image

If this fixes the issue for @tnn2 then I suggest we merge it.

@tnn2 Could you confirm this PR solves your issue?

@sithlord48

Copy link
Copy Markdown
Member Author

It should not do any extra harm its just not using a for each style loop now for two of the four loops involved.

@nbolton

nbolton commented Aug 14, 2025

Copy link
Copy Markdown
Member

You could land or wait for @tnn2 to confirm. Your call.

@sithlord48

sithlord48 commented Aug 14, 2025

Copy link
Copy Markdown
Member Author

He said in the issue it worked so we can land but i will not close the issue any more

@sithlord48
sithlord48 merged commit 04ca52b into master Aug 14, 2025
31 checks passed
@sithlord48
sithlord48 deleted the betterKeyMapParse branch August 14, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants