fix: resolve issues with some swedish characters - #8856
Conversation
|
@sithlord48 Nice. Do you have some good repro steps so I can see the bug happening on master? Do I need to switch to non-English layout? |
|
You will need to use a non US layout and try to send @ or | using the 3rd layer compositing. |
Maybe client? But I'll try both. |
|
I don't think this fixes the original bug reported in #8839 (which I originally tagged as a Wayland issue). I'm happy for #8839 to be repurposed as the X11 bug that @tnn2 is seeing. The original issue was for a Synergy 1.18 user which was long before a33574e so I'll simply clone #8839 to a new issue which is Wayland specific as before. With Wayland client, on both master and this PR, with a French layout on the client, the number row is quite messed up; it's all opposite.
Whether or not I choose 'Use server language' in preferences, it makes no difference to the behavior. I tried all combinations of server/client layout and it seems to only apply to the client.
If this fixes the issue for @tnn2 then I suggest we merge it. @tnn2 Could you confirm this PR solves your issue? |
|
It should not do any extra harm its just not using a for each style loop now for two of the four loops involved. |
e28476f to
956026b
Compare
|
You could land or wait for @tnn2 to confirm. Your call. |
|
He said in the issue it worked so we can land but i will not close the issue any more |

Partly solves: #8839