feat: remove toml config file only use our QSettings based format - #8849
Conversation
96437f9 to
c7eac5f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
nbolton
left a comment
There was a problem hiding this comment.
Right now, this feature is still valuable for running and debugging the Core (client/server) directly without the GUI.
If we remove it before we have a Qt settings replacement (where the Core reads directly from Qt settings rather than the CLI opts/args), we make Core development and testing harder in the short term. Implementing Qt settings first avoids that problem and gives us an immediate quality-of-life improvement.
We’ll need Qt settings eventually anyway, since passing Core options via the CLI is awkward/clumsy. A Qt settings file is cleaner, easier to maintain, and more aligned with how we’ll want to manage configuration long-term.
I’m happy to help build the replacement if you don’t want to take it on alone. But whichever way we do it, sequencing it before removing the TOML config parser means we avoid breaking current workflows while still moving toward the end goal.
|
I believe this is blocked by: I will prioritize working on this so we can delete the TOML parser. |
9a8f609 to
7e8274b
Compare
62f74fc to
0991e47
Compare
0991e47 to
6083236
Compare
remove deskflow/Config and related tests
6083236 to
09b8476
Compare
Fixes: #8129