Skip to content

feat: remove toml config file only use our QSettings based format - #8849

Merged
sithlord48 merged 1 commit into
masterfrom
dropToml
Oct 1, 2025
Merged

feat: remove toml config file only use our QSettings based format#8849
sithlord48 merged 1 commit into
masterfrom
dropToml

Conversation

@sithlord48

@sithlord48 sithlord48 commented Aug 12, 2025

Copy link
Copy Markdown
Member

Fixes: #8129

  • Remove support for toml based config files.

@sithlord48
sithlord48 requested a review from nbolton August 12, 2025 01:45
@sithlord48
sithlord48 force-pushed the dropToml branch 2 times, most recently from 96437f9 to c7eac5f Compare August 12, 2025 02:14
@github-actions

This comment was marked as outdated.

@nbolton nbolton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, this feature is still valuable for running and debugging the Core (client/server) directly without the GUI.

If we remove it before we have a Qt settings replacement (where the Core reads directly from Qt settings rather than the CLI opts/args), we make Core development and testing harder in the short term. Implementing Qt settings first avoids that problem and gives us an immediate quality-of-life improvement.

We’ll need Qt settings eventually anyway, since passing Core options via the CLI is awkward/clumsy. A Qt settings file is cleaner, easier to maintain, and more aligned with how we’ll want to manage configuration long-term.

I’m happy to help build the replacement if you don’t want to take it on alone. But whichever way we do it, sequencing it before removing the TOML config parser means we avoid breaking current workflows while still moving toward the end goal.

@nbolton

nbolton commented Aug 12, 2025

Copy link
Copy Markdown
Member

I believe this is blocked by:

I will prioritize working on this so we can delete the TOML parser.

@sithlord48
sithlord48 marked this pull request as ready for review September 30, 2025 11:09
@sithlord48
sithlord48 requested a review from nbolton September 30, 2025 11:09
@sithlord48
sithlord48 enabled auto-merge (rebase) September 30, 2025 11:31
@sithlord48
sithlord48 merged commit 4a5f173 into master Oct 1, 2025
35 of 59 checks passed
@sithlord48
sithlord48 deleted the dropToml branch October 1, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse arg with TOML config fails on Windows because of deallocated memory

2 participants