Skip to content

GUI: Move the shown ip location, only show when in server mode - #8847

Merged
sithlord48 merged 2 commits into
masterfrom
moveIPLocation
Aug 12, 2025
Merged

GUI: Move the shown ip location, only show when in server mode#8847
sithlord48 merged 2 commits into
masterfrom
moveIPLocation

Conversation

@sithlord48

@sithlord48 sithlord48 commented Aug 11, 2025

Copy link
Copy Markdown
Member

GUI

  • Use Link Color for coloring the ip to use
  • Move the gui display to the top right
  • show ONLY the suggested IP on the gui the rest are in a tooltip. no tooltip for a single ip
  • Only show the IP when in server mode.
Screenshot_20250811_172429 Screenshot_20250811_172518

I don't have a screen shot for the tooltip buts its

If connecting via the hostname fails, Try the following Ips:
 SuggestedIP (in color) 
 other ip 
 other ip
...

@sithlord48
sithlord48 requested a review from nbolton August 11, 2025 21:24
@sithlord48 sithlord48 changed the title Move ip location GUI: Move the shown ip location, only show when in server mode Aug 11, 2025
@sithlord48
sithlord48 force-pushed the moveIPLocation branch 3 times, most recently from affe9ac to 93b6079 Compare August 11, 2025 22:41
Comment thread src/lib/gui/MainWindow.cpp Outdated
Comment thread src/lib/gui/MainWindow.cpp Outdated
Comment thread src/lib/gui/MainWindow.cpp Outdated
Comment thread src/lib/gui/MainWindow.cpp Outdated
Comment thread src/lib/gui/MainWindow.ui Outdated
Comment thread src/lib/gui/MainWindow.cpp
nbolton
nbolton previously approved these changes Aug 12, 2025
 - Add a new method updateNetworkInfo to update lblIpAddresses
   This method can be hooked to the system network info in the future
   when we want to have this be more dynamic.
 - Only show the IP address when in server mode.
 - When showing the IP address show either the suggested IP or a message the user maybe offline
 - Use the linkVisited color to for our error message
@sithlord48
sithlord48 enabled auto-merge (rebase) August 12, 2025 16:46
@sithlord48
sithlord48 merged commit 0dfd4eb into master Aug 12, 2025
30 of 31 checks passed
@sithlord48
sithlord48 deleted the moveIPLocation branch August 12, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants