Use malloc to make IKEYState on win32 - #8826
Merged
Merged
Conversation
sithlord48
force-pushed
the
fixTestFail
branch
3 times, most recently
from
August 12, 2025 01:57
a426829 to
30fa311
Compare
sithlord48
changed the title
sithlord48
force-pushed
the
fixTestFail
branch
from
August 12, 2025 01:59
30fa311 to
6dab481
Compare
sithlord48
marked this pull request as ready for review
August 12, 2025 11:40
nbolton
reviewed
Aug 12, 2025
sithlord48
force-pushed
the
fixTestFail
branch
from
August 12, 2025 14:05
6dab481 to
9ff4c1b
Compare
sithlord48
enabled auto-merge (rebase)
August 12, 2025 15:40
nbolton
approved these changes
Aug 12, 2025
… failure in IKeyState
sithlord48
force-pushed
the
fixTestFail
branch
from
August 12, 2025 15:57
9ff4c1b to
8448bfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For windows we use malloc to make the IKeyState when made with a screen or buffer size.
I suspect this is causing random failures in the KeyTest.. running a bunch to see if i can trigger it .
Keeping this around for a bit incase it keeps happening
added guarding to keep sonar happy..