Skip to content

Sonar cleanup 14 - #8824

Merged
sithlord48 merged 15 commits into
masterfrom
sonarCleanup_14
Aug 11, 2025
Merged

Sonar cleanup 14#8824
sithlord48 merged 15 commits into
masterfrom
sonarCleanup_14

Conversation

@sithlord48

@sithlord48 sithlord48 commented Aug 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Next batch of sonar clean up

  • DaemonApp: provide context object for lambda
  • CoreProcess: fully qualify signal that send an enum
  • ScreenSetupModel::isFull compare const_iterators
  • Remove unneeded casts
  • Remove Arch::init() let arch call it from the base classes instead
  • Remove overrides from clientProxy1_4 that only call the base class
  • Use contains in server/config and server
  • define var on separate line from type
  • XWindowsScreen::handleSystemEvent, remove unused Window variables
  • reorder initialization order in XWindowEventQueueBuffer constructor
  • remove ServerConfig remove const from QString returns
  • refactor: ScreenSettingsDialog use qDeleteAll to clear list of items
  • Remove unneeed QObject:: for connect calls in DaemonApp
  • Remove unused Hyper key

@sithlord48
sithlord48 force-pushed the sonarCleanup_14 branch 2 times, most recently from 4705431 to e179bd0 Compare August 7, 2025 00:55
@sithlord48
sithlord48 marked this pull request as ready for review August 7, 2025 03:17
@sithlord48
sithlord48 requested a review from nbolton August 7, 2025 03:17
nbolton
nbolton requested changes Aug 7, 2025
View reviewed changes
Comment thread src/lib/arch/Arch.cpp
Comment thread src/lib/platform/EiKeyState.cpp
Comment thread src/lib/server/ClientProxy1_4.cpp
@sithlord48

sithlord48 commented Aug 7, 2025

Copy link
Copy Markdown
Member Author

@nbolton try again .. Arch on windows was not a sub class of ArchMiscWindows (it is now)

@sithlord48
sithlord48 requested a review from nbolton August 7, 2025 16:38
@sithlord48
sithlord48 force-pushed the sonarCleanup_14 branch 2 times, most recently from 0e46b16 to c3ed5f1 Compare August 7, 2025 17:44
nbolton
nbolton previously approved these changes Aug 7, 2025
View reviewed changes
@sithlord48
sithlord48 enabled auto-merge (rebase) August 7, 2025 20:25
@sithlord48
sithlord48 requested a review from nbolton August 7, 2025 21:59
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

github-actions Bot commented Aug 11, 2025

Copy link
Copy Markdown

CI Summary

Test result

❌🔬 Tests failed: 1

OS Unit tests Legacy tests
archlinux-x86_84 ✅ Pass ✅ Pass
debian-13-arm64 ✅ Pass ✅ Pass
debian-13-x86_64 ✅ Pass ✅ Pass
fedora-41-arm64 ✅ Pass ✅ Pass
fedora-41-x86_64 ✅ Pass ✅ Pass
fedora-42-arm64 ✅ Pass ✅ Pass
fedora-42-x86_64 ✅ Pass ✅ Pass
macos-13-x64 ✅ Pass ✅ Pass
macos-14-arm64 ✅ Pass ✅ Pass
opensuse-arm64 ✅ Pass ✅ Pass
opensuse-x86_84 ✅ Pass ✅ Pass
ubuntu-25.04-x86_64 ✅ Pass ✅ Pass
windows-2022-arm64 ❌ Fail ✅ Pass
windows-2022-x64 ✅ Pass ✅ Pass

Full summary (scroll down)

@sithlord48
sithlord48 merged commit 9442295 into master Aug 11, 2025
31 checks passed
@sithlord48
sithlord48 deleted the sonarCleanup_14 branch August 11, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sithlord48 @nbolton