refactor: Use cat directly when printing CI summary - #8822
Merged
Conversation
nbolton
changed the title
nbolton
force-pushed
the
fix-pr-comment-newlines
branch
from
August 6, 2025 12:04
58a9882 to
dc16872
Compare
Member
|
The message should be |
Wrapping in echo was stripping newlines.
nbolton
force-pushed
the
fix-pr-comment-newlines
branch
from
August 6, 2025 14:29
dc16872 to
f748395
Compare
sithlord48
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapping in echo was stripping newlines; right now, PR summary artifacts with newlines are printed in a big mess:
Testing: Because
.github/workflows/ci-comment.ymlonly runs onmaster(triggered by CI run), it has to be landed before we can properly test it.Blocks: #8821