chore: Improve logging for active sides - #8820
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
nbolton
marked this pull request as draft
August 6, 2025 10:28
nbolton
force-pushed
the
active-sides
branch
6 times, most recently
from
August 6, 2025 11:01
2af76d2 to
a222401
Compare
nbolton
marked this pull request as ready for review
August 6, 2025 11:01
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
I believe this is a transient failure on Windows ARM and unrelated to this PR: |
For the longest time, this log line has bugged me: ``` active sides: e ``` It's hex, but it looks like a bug, since there's no `0x` prefix. Also, most humans can't read hex, so I added a string representation. New version: ``` [2025-08-06T11:56:00] DEBUG: active sides: LRT (0x0e) ```
Member
|
Never had windows arm build fail on ci .. |
sithlord48
approved these changes
Aug 6, 2025
sithlord48
left a comment
sithlord48
left a comment
Member
There was a problem hiding this comment.
Looks ok to me , feel free to land
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the longest time, this log line has bugged me:
It's hex, but it looks like a bug, since there's no
0xprefix. Also, most humans can't read hex, so I added a string representation.New version: