Sonar cleanup 13 - #8810
Merged
Merged
Conversation
sithlord48
force-pushed
the
sonarCleanup_13
branch
3 times, most recently
from
August 5, 2025 02:40
56752dc to
e0ab6b8
Compare
sithlord48
marked this pull request as ready for review
August 5, 2025 13:04
sithlord48
force-pushed
the
sonarCleanup_13
branch
6 times, most recently
from
August 6, 2025 02:42
d517a0c to
d7f8853
Compare
nbolton
approved these changes
Aug 6, 2025
…nce in place of std::set_difference
nbolton
force-pushed
the
sonarCleanup_13
branch
from
August 6, 2025 10:28
d7f8853 to
f24c3e3
Compare
nbolton
enabled auto-merge (rebase)
August 6, 2025 10:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next round of sonar clean up:
m_socketbeforem_eventsm_byeprivate and access via existing methodbyestd::ranges::set_differenceKeyMap,Action,KeySequence,Fingerprint