Skip to content

Sonar cleanup 13 - #8810

Merged
nbolton merged 12 commits into
masterfrom
sonarCleanup_13
Aug 6, 2025
Merged

Sonar cleanup 13#8810
nbolton merged 12 commits into
masterfrom
sonarCleanup_13

Conversation

@sithlord48

@sithlord48 sithlord48 commented Aug 4, 2025

Copy link
Copy Markdown
Member

Next round of sonar clean up:

  • TCPSocket: init m_socket before m_events
  • ServerConfig: use ranged loops for screens section
  • IKeyState: directly send args for string creation to emplace
  • IKeyState: Remove use of malloc (+ use auto now for the type)
  • App: make m_bye private and access via existing method bye
  • DisplayInvalidException remove unneeded constructors on non mac os
  • MSWindowsDesks::getCursorPos, initialize pos to 0,0
  • KeyState::updateModifierState, use std::ranges::set_difference
  • KeyTypes::KeyModifierNameMapEntry, remove commented code
  • AppUtilUnix remove name from unused IEventQueue pointer
  • Use default == operator for KeyMap, Action, KeySequence, Fingerprint
  • server/Config remove redundant != operator

@sithlord48
sithlord48 force-pushed the sonarCleanup_13 branch 3 times, most recently from 56752dc to e0ab6b8 Compare August 5, 2025 02:40
@sithlord48
sithlord48 requested a review from nbolton August 5, 2025 13:04
@sithlord48
sithlord48 marked this pull request as ready for review August 5, 2025 13:04
@sithlord48
sithlord48 force-pushed the sonarCleanup_13 branch 6 times, most recently from d517a0c to d7f8853 Compare August 6, 2025 02:42
@nbolton
nbolton enabled auto-merge (rebase) August 6, 2025 10:28
@nbolton
nbolton merged commit 4042339 into master Aug 6, 2025
31 checks passed
@nbolton
nbolton deleted the sonarCleanup_13 branch August 6, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants