Sonar cleanup 12 - #8805
Merged
Merged
Conversation
sithlord48
marked this pull request as ready for review
August 2, 2025 13:50
sithlord48
force-pushed
the
sonarCleanup_12
branch
2 times, most recently
from
August 3, 2025 03:28
db50017 to
ab7eaab
Compare
sithlord48
marked this pull request as draft
August 3, 2025 03:28
sithlord48
force-pushed
the
sonarCleanup_12
branch
from
August 3, 2025 04:43
9fbd82b to
d86028b
Compare
sithlord48
marked this pull request as ready for review
August 3, 2025 05:01
nbolton
previously approved these changes
Aug 4, 2025
nbolton
left a comment
nbolton
left a comment
Member
There was a problem hiding this comment.
OK to land, but one minor nit if you want to fix.
…Job, FunctionEventJob, ServerConfig, ScreenSettingsDialog, KeySequenceWidget, NetworkAddress, AddClientDialog, ConfigReadContext, LockCursorToScreenAction, RestartServer And KeyboardBroadcastAction
…e protected methods to acces them in the subclasses
…Error to base App Class
sithlord48
force-pushed
the
sonarCleanup_12
branch
from
August 4, 2025 12:08
d86028b to
d353d24
Compare
nbolton
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next round of sonar "issues" cleanup
explicitfor a bunch of constructiorsStopWatch::double()App::m_eventsprivate, access it from existingApp::getEvents()in the sub classesTCPListenSocketprotected var's private and access via protected methods in subclassesTCPSocket::m_eventsprivate access it from getEvents() in sub classes.TcpSocket::outputBuffer/TcpSocket::inputBufferprivate with protected member access did build but resulted in failure to connect.ClientApp::handleScreenErrorandServerApp::handleScreenErrorintoApp::handleScreenErrorApp::m_byeprotected memberdo nothingmethodsClientApp::updateStatus(...)andServerApp::updateStatus(...)(was even calling it in places)