Skip to content

Sonar Cleanup 10 - #8794

Merged
nbolton merged 6 commits into
masterfrom
sonarCleanup_10
Jul 31, 2025
Merged

Sonar Cleanup 10#8794
nbolton merged 6 commits into
masterfrom
sonarCleanup_10

Conversation

@sithlord48

@sithlord48 sithlord48 commented Jul 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Next round of Sonar updates, This round includes the following

  • Replace use of Synergy name in clipboard test with Deskflow
  • IClipboard::EFormat => Enum class IClipbpoard::Format
  • ServerApp:EServerState => Enum class ServerApp::ServerState
  • AddResults => enum class ScreenAddResults
  • Remove Screen Corner enums and replace with a set of statics
  • Unify ENetworkProtocol and ServerProtocol in a new enum class NetworkProtocol in file base/Networkprotocol.h

@sithlord48
sithlord48 force-pushed the sonarCleanup_10 branch 2 times, most recently from b532611 to 474b953 Compare July 30, 2025 23:37
@sithlord48
sithlord48 requested a review from nbolton July 31, 2025 00:23
@sithlord48
sithlord48 marked this pull request as ready for review July 31, 2025 00:42
nbolton
nbolton previously approved these changes Jul 31, 2025
View reviewed changes
Comment thread src/lib/base/Enum_NetworkProtocol.h
@sithlord48
refactor: Unify ENetworkProtocol and ServerProtocol into new enum Cla…
7a74a59 
…ss NetworkProtocol in new file base/NetworkProtocol.h
@sithlord48
sithlord48 requested a review from nbolton July 31, 2025 12:25
@nbolton
nbolton enabled auto-merge (rebase) July 31, 2025 12:33
@nbolton
nbolton merged commit f73d098 into master Jul 31, 2025
31 checks passed
@nbolton
nbolton deleted the sonarCleanup_10 branch July 31, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sithlord48 @nbolton