Skip to content

Sonar cleanup 9 - #8779

Merged
nbolton merged 6 commits into
masterfrom
sonarCleanup_9
Jul 29, 2025
Merged

Sonar cleanup 9#8779
nbolton merged 6 commits into
masterfrom
sonarCleanup_9

Conversation

@sithlord48

@sithlord48 sithlord48 commented Jul 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Fix more sonar issues

  • Refactor: ActionDialog to use proper method in place of lambda
  • PriorityQueue: use std::ranges version of heap methods
  • KeyMap::mapCommandKey and keysToRestoreModifier use ranged loops
  • More Enum Classes
    • KeyMap's EType => KeyMap::KeyType
  • Explicit constructor for Event's not default constructors.

@sithlord48
sithlord48 force-pushed the sonarCleanup_9 branch 2 times, most recently from 96bd236 to 517d52b Compare July 28, 2025 14:43
@sithlord48
sithlord48 requested a review from nbolton July 29, 2025 12:04
@sithlord48
sithlord48 marked this pull request as ready for review July 29, 2025 12:05
@nbolton
nbolton merged commit 49e36cf into master Jul 29, 2025
85 of 86 checks passed
@nbolton
nbolton deleted the sonarCleanup_9 branch July 29, 2025 12:41
@sithlord48 sithlord48 added the 🗒️ task Doesn't directly add new functionality or fix bugs in the program label Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes

Assignees

No one assigned

Labels

🗒️ task Doesn't directly add new functionality or fix bugs in the program

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sithlord48 @nbolton