Conversation
nbolton
approved these changes
Jul 21, 2025
nbolton
left a comment
Member
There was a problem hiding this comment.
I don't know how to repro the bug, but LGTM on KDE and GNOME (though GNOME doesn't show a title icon anymore).
Member
Author
|
fyi: to repo i installed debian trixie w/ xfce (x11) on a clean vm |
Member
Ah, it was Xfce, should have guessed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8756
Set the mainwindow icon explicitly to our theme icon . This is mainly noticeable on X11 desktops that don't use rev FQDN lookup for icon matching and the default icon for a window is show instead of ours.