Skip to content

build: generate vcpkg.json on windows - #8763

Merged
sithlord48 merged 3 commits into
masterfrom
updateVpckgFile
Jul 21, 2025
Merged

build: generate vcpkg.json on windows#8763
sithlord48 merged 3 commits into
masterfrom
updateVpckgFile

Conversation

@sithlord48

@sithlord48 sithlord48 commented Jul 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

I got tired of seeing those vcpkg files in the repo..
Instead lets use a template to generate them

  • do not allow vcpkg.json to be added to the repo
  • provide a new option VCPKG_QT (default is OFF), to build Qt via vcpkg
  • use cmake/vcpkg.json.in to configure our vcpkg.json
  • Generate our vcpkg.json before calling project so ides pick it up correctly.
  • Use the vcpkg provided windeployqt if debug and VCPKG_QT
  • Fail configuration if Unable to find the Qt Deploy Tool needed
  • REUSE.toml use arrays to group files with the same overrides

@sithlord48
sithlord48 requested a review from nbolton July 17, 2025 15:47
@sithlord48 sithlord48 added 🪟 windows This issue affects Windows 🗒️ task Doesn't directly add new functionality or fix bugs in the program labels Jul 17, 2025
nbolton
nbolton reviewed Jul 17, 2025
View reviewed changes
Comment thread doc/dev/build.md
nbolton
nbolton requested changes Jul 17, 2025
View reviewed changes
Comment thread doc/dev/build.md Outdated
Comment thread cmake/vcpkg.json.in Outdated
Comment thread cmake/vcpkg.json.in
Comment thread cmake/vcpkg.json.in
@sithlord48
sithlord48 force-pushed the updateVpckgFile branch 2 times, most recently from b8844d8 to c61355b Compare July 17, 2025 17:48
@sithlord48
sithlord48 requested a review from nbolton July 17, 2025 18:54
@nbolton

This comment was marked as outdated.

Sign in to view
nbolton
nbolton requested changes Jul 18, 2025
View reviewed changes
Comment thread cmake/vcpkg.json.in Outdated
nbolton
nbolton reviewed Jul 18, 2025
View reviewed changes
Comment thread doc/dev/build.md Outdated
@nbolton

This comment was marked as outdated.

Sign in to view
@sithlord48

sithlord48 commented Jul 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Hmm, getting a strange error. I set CMAKE_PREFIX_PATH to C:\Qt\6.8.3\msvc2022_64 -- I wonder if that's incorrect. I do have windeployqt.exe in C:\Qt\6.8.3\msvc2022_64\bin so I'm at a loss for what to do.

You don't. I think I need to change that to AND VCPKG_QT. The bat file is something vcpkg adds to qt's install to run windeploy qt in debug mode correctly its not part of normal Qt installs

@sithlord48
sithlord48 requested a review from nbolton July 18, 2025 13:15
@sithlord48 sithlord48 added this to the v1.23.0 milestone Jul 18, 2025
@sithlord48
sithlord48 force-pushed the updateVpckgFile branch 2 times, most recently from 76dcc34 to ede66c6 Compare July 19, 2025 15:09
nbolton
nbolton previously approved these changes Jul 21, 2025
View reviewed changes
Comment thread cmake/Libraries.cmake
Comment thread doc/dev/build.md Outdated
@sithlord48
sithlord48 requested a review from nbolton July 21, 2025 11:39
nbolton
nbolton previously approved these changes Jul 21, 2025
View reviewed changes

@nbolton nbolton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar nazi strikes!

Comment thread cmake/Libraries.cmake Outdated
Comment thread doc/dev/build.md Outdated
Comment thread doc/dev/build.md Outdated
Comment thread doc/dev/build.md Outdated
Comment thread doc/dev/build.md Outdated
@sithlord48
sithlord48 enabled auto-merge (rebase) July 21, 2025 13:56
@sithlord48
sithlord48 requested a review from nbolton July 21, 2025 14:02
nbolton
nbolton approved these changes Jul 21, 2025
View reviewed changes
Comment thread cmake/Libraries.cmake
@sithlord48
sithlord48 merged commit 9a79929 into master Jul 21, 2025
31 checks passed
@sithlord48
sithlord48 deleted the updateVpckgFile branch July 21, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes

Assignees

No one assigned

Labels

🗒️ task Doesn't directly add new functionality or fix bugs in the program 🪟 windows This issue affects Windows

Projects

None yet

Milestone

v1.23.0

Development

Successfully merging this pull request may close these issues.

2 participants

@sithlord48 @nbolton