Skip to content

Windows Installer: Add Post install run option, cleanup background template - #8751

Merged
nbolton merged 3 commits into
masterfrom
fix_8351
Jul 17, 2025
Merged

Windows Installer: Add Post install run option, cleanup background template#8751
nbolton merged 3 commits into
masterfrom
fix_8351

Conversation

@sithlord48

@sithlord48 sithlord48 commented Jul 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

fixes: #8754

  • new background image for the installer.
  • Adjust sizes for banner and background to be properly sized
  • new Background
wix-dialog

fixes: #8351

  • Adds a check box to the windows installer letting users run deskflow post install
  • Defaults on. Was not able to get it to run post install via msiexec /qn

fixes issue on ci with x64 windows runner by forcing ninja to be updated.

Split settings clean up into #8757

@sithlord48
sithlord48 requested a review from nbolton July 14, 2025 15:11
@sithlord48 sithlord48 added the 🪟 windows This issue affects Windows label Jul 14, 2025
@sithlord48
sithlord48 marked this pull request as draft July 14, 2025 15:13
@sithlord48
sithlord48 force-pushed the fix_8351 branch 2 times, most recently from 0c59828 to 73e9970 Compare July 14, 2025 17:47
@sithlord48
sithlord48 marked this pull request as ready for review July 14, 2025 17:49
@sithlord48 sithlord48 mentioned this pull request Jul 14, 2025
Closed
@sithlord48 sithlord48 added the 🪄 feature request This PR adds a requested feature label Jul 14, 2025
@sithlord48 sithlord48 mentioned this pull request Jul 15, 2025
Open
12 tasks
@sithlord48 sithlord48 changed the title Windows Installer: Add option to run deskflow after install for … Windows Installer: Improve Uninstall and Add Post install run option Jul 15, 2025
@nbolton

nbolton commented Jul 16, 2025

Copy link
Copy Markdown
Member

Gah, I hate testing the Windows installer 😜

Hmm, probably unrelated to this PR, but seeing this now:
image
image

Fixed by deleting then manually re-creating the C:\ProgramData\Deskflow dir.

nbolton
nbolton requested changes Jul 16, 2025
View reviewed changes
Comment thread deploy/windows/wix-patch.xml.in Outdated
Comment thread deploy/windows/wix-patch.xml.in
@nbolton

This comment was marked as off-topic.

Sign in to view
@sithlord48

This comment was marked as off-topic.

Sign in to view
@sithlord48 sithlord48 mentioned this pull request Jul 16, 2025
Closed
@sithlord48
sithlord48 marked this pull request as draft July 16, 2025 15:18
@sithlord48 sithlord48 changed the title Windows Installer: Improve Uninstall and Add Post install run option Windows Installer: Add Post install run option, cleanup background template Jul 16, 2025
@sithlord48 sithlord48 mentioned this pull request Jul 16, 2025
Closed
@sithlord48
sithlord48 requested a review from nbolton July 16, 2025 18:33
@sithlord48
sithlord48 marked this pull request as ready for review July 16, 2025 18:34
@nbolton

This comment was marked as outdated.

Sign in to view
@nbolton

nbolton commented Jul 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Weird build error... seems like it might be transient (I will retry):

[319/342] Linking CXX executable bin\deskflow.exe
FAILED: [code=3221226505] bin/deskflow.exe 
C:\Windows\system32\cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_exe --msvc-ver=1944 --intdir=src\apps\deskflow-gui\CMakeFiles\deskflow.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100261~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100261~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1444~1.352\bin\Hostx64\x64\link.exe /nologo src\apps\deskflow-gui\CMakeFiles\deskflow.dir\deskflow_autogen\mocs_compilation.cpp.obj src\apps\deskflow-gui\CMakeFiles\deskflow.dir\deskflow.rc.res src\apps\deskflow-gui\CMakeFiles\deskflow.dir\deskflow-gui.cpp.obj src\apps\deskflow-gui\CMakeFiles\deskflow.dir\deskflow_autogen\WG5ICXO7IL\qrc_deskflow.cpp.obj src\apps\deskflow-gui\CMakeFiles\deskflow.dir\__\__\__\vcpkg\installed\x64-windows-release\include\openssl\applink.c.obj  /out:bin\deskflow.exe /implib:src\apps\deskflow-gui\deskflow.lib /pdb:bin\deskflow.pdb /version:0.0 /machine:x64 /INCREMENTAL:NO /subsystem:windows /NODEFAULTLIB:LIBCMT  src\lib\gui\gui.lib  src\lib\common\
[320/342] Linking CXX executable bin\deskflow-client.exe
[321/342] Linking CXX executable src\unittests\base\XBaseTests.exe
[322/342] Linking CXX executable src\unittests\common\SettingsTests.exe
[323/342] Linking CXX executable src\unittests\deskflow\ArgParserTests.exe
[324/342] Linking CXX executable src\unittests\deskflow\ClipboardTests.exe
[325/342] Linking CXX executable src\unittests\deskflow\ClipboardChunksTests.exe
[326/342] Linking CXX executable src\unittests\deskflow\ConfigTests.exe
ninja: build stopped: subcommand failed.
Exit code 0xc0000409
CMake Error: Generator: execution of make failed. Make command was: C:/ProgramData/chocolatey/bin/ninja.exe -j 8 package
Error: Process completed with exit code 1.

Edit: Hmm, still failing. Maybe not transient after all?

@sithlord48

sithlord48 commented Jul 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Looks nice on it's own...
image

But the gradient maybe looks a bit retro (perhaps because of the subtle color banding). Somehow looks more retro when shown in the installer UI. Solid backgrounds tend to look more modern. Thinking out loud... Do we need a background color at all?

We do not but then it looks ever worse w/ just an area that is just using the background color and everything then looks like is no longer centered properly.

We could remove the background all together but then we get the default left panel look where its this ugly red pattern.

Edit: This image is in 256 indexed color mode the banding is intended part of the image.

@sithlord48
sithlord48 force-pushed the fix_8351 branch 2 times, most recently from 6d37589 to ea5f7c7 Compare July 17, 2025 12:27
@sithlord48
sithlord48 marked this pull request as draft July 17, 2025 13:10
@sithlord48
feat: windows/installer add option to run deskflow after install for …
694d460 
…silent installs fixes #8351

      adjust installer background image to fit better in this case
@sithlord48
fix: adjust windows installer images and their sizes, remove synergy …
3b75302 
…background image from install fixes #8754
@sithlord48
sithlord48 marked this pull request as ready for review July 17, 2025 13:48
@nbolton
nbolton merged commit 6bf25c0 into master Jul 17, 2025
58 of 59 checks passed
@nbolton
nbolton deleted the fix_8351 branch July 17, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes

Assignees

No one assigned

Labels

🪄 feature request This PR adds a requested feature 🪟 windows This issue affects Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace remaining Synergy branding graphics with Deskflow (Windows) Add option to not auto-start on install

2 participants

@sithlord48 @nbolton