Skip to content

chore: MainWindow, Use system monospace font in log - #8750

Merged
sithlord48 merged 2 commits into
masterfrom
noForcelogFont
Jul 18, 2025
Merged

chore: MainWindow, Use system monospace font in log#8750
sithlord48 merged 2 commits into
masterfrom
noForcelogFont

Conversation

@sithlord48

@sithlord48 sithlord48 commented Jul 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Use the system's monospace font for the log.
Bump the font size up a bit for macOS to 12px. Its default is way to small.

fixes : maybe some of #7865 , Others?

windows runner was updated to ninja 1.13.1 so reverting the commit to update it with our action

@sithlord48
sithlord48 requested a review from nbolton July 14, 2025 13:57
@sithlord48 sithlord48 mentioned this pull request Jul 14, 2025
Closed
12 tasks
@sithlord48
sithlord48 force-pushed the noForcelogFont branch 2 times, most recently from d77aa3f to 765efd5 Compare July 15, 2025 13:50
@nbolton

This comment was marked as outdated.

Sign in to view
@sithlord48

sithlord48 commented Jul 16, 2025

Copy link
Copy Markdown
Member Author

@nbolton fixed.

@nbolton

This comment was marked as outdated.

Sign in to view
@sithlord48

This comment was marked as outdated.

Sign in to view
nbolton
nbolton reviewed Jul 17, 2025
View reviewed changes
Comment thread src/lib/gui/MainWindow.cpp Outdated
Comment thread src/lib/gui/MainWindow.cpp Outdated
@sithlord48
sithlord48 force-pushed the noForcelogFont branch 3 times, most recently from 6ec55b2 to 4387e02 Compare July 17, 2025 17:53
@sithlord48
sithlord48 requested a review from nbolton July 17, 2025 17:54
@sithlord48
sithlord48 force-pushed the noForcelogFont branch 2 times, most recently from eabd410 to 9266273 Compare July 17, 2025 18:25
@sithlord48 sithlord48 changed the title chore: MainWindow, do not force a specific font in the log chore: MainWindow, Use system monospace font in log Jul 17, 2025
@nbolton

nbolton commented Jul 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Looks good (actually better) on GNOME, KDE, and Windows... but I'm not so sure about macOS. I find the smaller font harder to read.

Here's how default Qt fixed width looks against the macOS Terminal app default:

Screenshot 2025-07-18 at 11 24 15 Screenshot 2025-07-18 at 11 25 38

What do you think about setting a specific font (SF Mono) just for macOS? I believe this font will always be available on macOS since it's the default that Apple uses. Alternatively, Menlo is a popular choice on macOS for consoles.

Edit: Maybe macOS is fine and I'm just not used to it. Open to feedback on that one as it's pretty subjective. Land as-is if you feel like it's fine.

macOS

Before

Screenshot 2025-07-18 at 11 30 26

After

Screenshot 2025-07-18 at 11 27 49

Windows

Before

image

After

image

GNOME

Quite similar, but a bit nicer after.

Before

image

After

image

KDE

Before

image

After

image

nbolton
nbolton previously approved these changes Jul 18, 2025
View reviewed changes
@sithlord48

sithlord48 commented Jul 18, 2025

Copy link
Copy Markdown
Member Author

Leave it to mac os to have a Smaller then needed font for the system default monospace .. let me see if i can bump it up a bit

@sithlord48
sithlord48 requested a review from nbolton July 18, 2025 12:11
@sithlord48 sithlord48 added this to the v1.23.0 milestone Jul 18, 2025
@sithlord48

sithlord48 commented Jul 18, 2025

Copy link
Copy Markdown
Member Author

Gonna land. Approval got removed when addressing mac os log size.

@sithlord48
sithlord48 merged commit 21d38ff into master Jul 18, 2025
57 of 58 checks passed
@sithlord48
sithlord48 deleted the noForcelogFont branch July 18, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton Awaiting requested review from nbolton nbolton is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.23.0

Development

Successfully merging this pull request may close these issues.

2 participants

@sithlord48 @nbolton