Skip to content

InputCapture portal Improvements - #8749

Merged
nbolton merged 2 commits into
masterfrom
ic_cleanup
Jul 14, 2025
Merged

InputCapture portal Improvements#8749
nbolton merged 2 commits into
masterfrom
ic_cleanup

Conversation

@sithlord48

@sithlord48 sithlord48 commented Jul 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

fixes #8572
fixes #8452
fixes #8605
any remaining cases of #8005
Maybe more as well as those cases where the mouse could just vanish when it touched an edge (at least for wayland)

  • Remove un needed InputCapturePortal::fakeEisFd method
  • Set only the barriers that have a screen next to them on wayland
    • Move Direction and DirectionMask enums to base/DirectionTypes.h
    • Add IPrimaryScreen::activeSides to return the side mask
    • Implement IPrimaryScreen::refactor in the subclasses
    • Use activeSide data to set zones used when making the InputCapture portal request

@sithlord48 sithlord48 added the 🩹 fix This PR fixes a reported bug label Jul 13, 2025
@sithlord48
sithlord48 marked this pull request as ready for review July 13, 2025 14:48
@sithlord48
sithlord48 requested a review from nbolton July 13, 2025 14:48
@sithlord48 sithlord48 added this to the v1.23.0 milestone Jul 13, 2025
@sithlord48
sithlord48 force-pushed the ic_cleanup branch 3 times, most recently from 1e85281 to b0781ce Compare July 13, 2025 15:52
@sithlord48
feat: Wayland, only set a side to a border if if has a neighboring sc…
a4e2a18 
…reen

move protocolTypes Direction enum to new base/DirectionTypes
use the direction info when calling
fixes #8572
fixes #8452
fixes #8605
fixes #8005
@sithlord48 sithlord48 changed the title InputCapture portal Improvments InputCapture portal Improvements Jul 13, 2025
@nbolton
nbolton merged commit f51abad into master Jul 14, 2025
31 checks passed
@nbolton
nbolton deleted the ic_cleanup branch July 14, 2025 09:31
@SnDream

SnDream commented Jul 14, 2025

Copy link
Copy Markdown

I'd like to ask whether this processing logic also covers Dead corners? For instance, does it deduct the corresponding capture width for edges configured with Dead corners?

@sithlord48

sithlord48 commented Jul 14, 2025

Copy link
Copy Markdown
Member Author

I'd like to ask whether this processing logic also covers Dead corners? For instance, does it deduct the corresponding capture width for edges configured with Dead corners?

No just fixes up the logic to not place borders on sides without them .

@sithlord48 sithlord48 mentioned this pull request Aug 5, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes

Assignees

No one assigned

Labels

🩹 fix This PR fixes a reported bug

Projects

None yet

Milestone

v1.23.0

Development

Successfully merging this pull request may close these issues.

Corners configured in KDE Screen Edges don't work with Deskflow running Screen Edges Unneeded barriers interfere with window management

3 participants

@sithlord48 @SnDream @nbolton