Sonar cleanup 7 - #8744

Next Round of sonar cleanup

• Use std::ignore instead of unused int
• replace throw() with noexcept in some cases (no exception possible)
• Remove enums and replace with static items
  • LogOutputters::EFileLogOutputter, use constexpr instead s_logFileSizeLimit
  • Anonymous enum in Common.h => set of s_exit<Status> vars
  • Anonymous enum in IKeyState => s_numButtons
  • Anonymous enum in EiEventQueue = > set of s_ vars local to the method they are used in
  • Anonymous enum in XWindowsKeyState = > set of s_ vars
  • Remove unused Anonymous enum in SecureSocket
  • ActionDialog::ActionTypes is now a struct of values.
• More enum classes
  • anonymous enum in Event.h => EventFlags enum class.
  • ELevel => LogLevel enum class
  • IEventQueueBuffer::Type now enum class.
  • ServerProxy::EResult => ServerProxy::ConnectionResult enum class
  • ArgsBase::Type => ArgsBase::ClassType enum class
  • make ClientApp::ClientScrollDirection an enum class, use Normal and Inverted for member names.
  • TCPSocket::EJobResult => TCPSocket::JobResult enum class
  • XSocket::EError => XSocket:SocketError enum class
  • anonymous enum in AddClientDialog => AddClientDialog::AddAction enum class.
  • anonymous enum in ServerConfig => ServerConfig::AddResults enum class.