More Sonar Cleanup (round 5) - #8732
Merged
Merged
Conversation
sithlord48
force-pushed
the
sonarCleanup_4
branch
9 times, most recently
from
July 1, 2025 04:16
cd60592 to
fd6ddd1
Compare
sithlord48
marked this pull request as ready for review
July 1, 2025 05:36
sithlord48
force-pushed
the
sonarCleanup_4
branch
3 times, most recently
from
July 1, 2025 14:00
9176c83 to
7f74f50
Compare
nbolton
previously approved these changes
Jul 2, 2025
nbolton
left a comment
nbolton
left a comment
Member
There was a problem hiding this comment.
Good as is, only one minor nit. Up to you if you land or fix now.
sithlord48
force-pushed
the
sonarCleanup_4
branch
from
July 3, 2025 02:54
7f74f50 to
4fc34db
Compare
sithlord48
enabled auto-merge (rebase)
July 3, 2025 02:55
Member
Author
Ok updated with your suggestion and if the build passes ill land it. |
…conform ThreadSignal items to naming conventions
…AddressFamily confirm AddressFamily items to naming convention
… to naming conventions
…with set of static values
make throwError and throwNameError noreturn
remove unused extra private section in IArchNetwork subclasses
sithlord48
force-pushed
the
sonarCleanup_4
branch
from
July 3, 2025 03:01
4fc34db to
df67a2d
Compare
sithlord48
disabled auto-merge
July 3, 2025 03:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up more sonar issues
IArchMultiThread::ESignalMake a enum class and rename toThreadSignal, conform members names.IArchNetwork::EAddressFamilymake enum class and rename toAddressFamily, conform members names.IArchNetwork::EStreamTypemake enum class and rename toStreamType, conform members names.PollEventMaskstructusing enum EventTypesin places with 3 or more eventsthrowErrorandthrowNameErrorintoIArchNetworkthrowErrorandthrowNameError[[noreturn]]