Skip to content

chore: fix W:useless-whatis-entry lintian warnings - #8728

Merged
sithlord48 merged 1 commit into
deskflow:masterfrom
kenhys:useless-whatis-entry
Jul 3, 2025
Merged

chore: fix W:useless-whatis-entry lintian warnings#8728
sithlord48 merged 1 commit into
deskflow:masterfrom
kenhys:useless-whatis-entry

Conversation

@kenhys

@kenhys kenhys commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

By default, help2man generates "manual page for foobar" for manual files.

It is useless because there is no addtional information which explains what deskflow is.

With --name option, .SH NAME section will be set correctly.

Before:

  .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
  .TH DESKFLOW-CLIENT "1" "June 2025" "deskflow-client v1.22.0.109, protocol v1.8" "User Commands"
  .SH NAME
  deskflow-client \- manual page for deskflow-client v1.22.0.109, protocol v1.8
  .SH SYNOPSIS
  .B deskflow-client
  [\fI\,OPTIONS\/\fR]
  .SH DESCRIPTION

After:

  .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
  .TH DESKFLOW-CLIENT "1" "June 2025" "deskflow-client v1.22.0.110, protocol v1.8" "User Commands"
  .SH NAME
  deskflow-client \- Keyboard and mouse sharing client
  .SH SYNOPSIS
  .B deskflow-client
  [\fI\,OPTIONS\/\fR]
  .SH DESCRIPTION

@sithlord48

Copy link
Copy Markdown
Member

Can you show me an example of the output before and after this

@kenhys
kenhys force-pushed the useless-whatis-entry branch from 6e1943e to 8c456eb Compare June 30, 2025 11:50
@kenhys

kenhys commented Jun 30, 2025

Copy link
Copy Markdown
Contributor Author

Updated commit message.

@sithlord48 sithlord48 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty much the CMAKE_PROJECT_DESCRIPTION that is just a few lines down. Instead of repeating the Description for the project we put something else that is more descriptive for each of the executables

@nbolton

nbolton commented Jul 2, 2025

Copy link
Copy Markdown
Member

Next steps?

@sithlord48

Copy link
Copy Markdown
Member

I would like to see if we can come up with better descriptions then just reusing the project description to describe each application.

@nbolton

nbolton commented Jul 3, 2025

Copy link
Copy Markdown
Member

@kenhys Any interest in improving your PR?

By default, help2man generates "manual page for foobar" for
manual files.

It is useless because there is no addtional information which
explains what deskflow is.

With --name option, .SH NAME section will be set correctly.

Before:

  .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
  .TH DESKFLOW-CLIENT "1" "June 2025" "deskflow-client v1.22.0.109, protocol v1.8" "User Commands"
  .SH NAME
  deskflow-client \- manual page for deskflow-client v1.22.0.109, protocol v1.8
  .SH SYNOPSIS
  .B deskflow-client
  [\fI\,OPTIONS\/\fR]
  .SH DESCRIPTION

After:

  .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
  .TH DESKFLOW-CLIENT "1" "July 2025" "deskflow-client v1.22.0.109, protocol v1.8" "User Commands"
  .SH NAME
  deskflow-client \- Keyboard and mouse sharing utility (Client)
  .SH SYNOPSIS
  .B deskflow-client
  [\fI\,OPTIONS\/\fR]
  .SH DESCRIPTION

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
kenhys force-pushed the useless-whatis-entry branch from 8c456eb to ff79830 Compare July 3, 2025 09:51

@sithlord48 sithlord48 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the best description but its at least using the cmake project description for the string now (and not a new duplicated string). While not ideal i think its a good start If we think of better descriptive strings we can improve them later on.

@sithlord48
sithlord48 merged commit 5976da7 into deskflow:master Jul 3, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants