chore: simplify icon theme path fallback path - #8718
Merged
Conversation
sithlord48
force-pushed
the
simplifyIconThemeSetting
branch
3 times, most recently
from
June 24, 2025 19:22
06c4efa to
4c0dfeb
Compare
Member
|
On
Looks like not introduced by your PR and it slipped through at some point. p.s. Damn you for making me use light mode :p (my eyes, my eyes...) |
nbolton
previously approved these changes
Jun 25, 2025
nbolton
force-pushed
the
simplifyIconThemeSetting
branch
from
June 25, 2025 15:03
4c0dfeb to
4ea14c8
Compare
nbolton
enabled auto-merge (rebase)
June 25, 2025 15:03
…re sub dirs but we should only need the theme root refactor: set the Icon theme in deskflow-gui insetead of MainWindow
sithlord48
force-pushed
the
simplifyIconThemeSetting
branch
from
June 25, 2025 15:40
4ea14c8 to
963f97f
Compare
Member
Author
|
@nbolton updated i think its got confused by both icons being there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify how we resolve the fallback search paths.
StyleUtil::checkSubDiris not needed and has been removed:icons/deskflow-lightor:/icons/deskflow-darkStyleUtil::SetFallbackThemePathhas been removed and just is set in deskflow-gui.cpp