fix: Error text is not shown for Qt CLI parser - #8692
Merged
Conversation
Member
|
we don't need the method for this but otherwise seams ok will test out later |
sithlord48
reviewed
Jun 16, 2025
nbolton
force-pushed
the
parser-error-text
branch
from
June 18, 2025 12:07
c5f44ba to
a912309
Compare
nbolton
enabled auto-merge (rebase)
June 18, 2025 12:08
nbolton
force-pushed
the
parser-error-text
branch
from
June 18, 2025 12:27
a912309 to
537651e
Compare
sithlord48
requested changes
Jun 18, 2025
nbolton
force-pushed
the
parser-error-text
branch
from
June 18, 2025 12:33
537651e to
536388b
Compare
sithlord48
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #8685
We should print the parser error text to stderr and return non-zero exit code so that it's clear when you enter an invalid option.
As it is, it's a bit confusing how it doesn't tell you when you enter an invalid arg.