feat: improve connections status bar info - #8690
Merged
Merged
Conversation
sithlord48
force-pushed
the
feat_better_connection_status
branch
from
June 15, 2025 12:49
7ed1636 to
90d3b55
Compare
sithlord48
marked this pull request as ready for review
June 15, 2025 12:54
nbolton
force-pushed
the
feat_better_connection_status
branch
from
June 16, 2025 09:17
90d3b55 to
f6fc60d
Compare
nbolton
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #8688
Modify the status area to show different message on connections
ServerConnection Changes:
QStringList m_receivedClients=>QSet<QString> m_connectedClients(set items are unique)MainWindows Changes:
Clients will show
Deskflow is connected as client of <serverName>Servers will show a few things depends on the number of clients
No clients:
Deskflow is waiting for clients1 Client:
Deskflow is connected to a client: <clientName> 2-4 Clients:Deskflow is connected N clients: , , ,5+ Clients:
Deskflow is connected to N clientsIf any more then one client is connected the client list is set to the status bars tooltip in a message like
Can be tested from the artifacts from the Ci job : https://github.com/deskflow/deskflow/actions/runs/15663414272