Skip to content

chore: Remove 1024 TLS key length option - #8671

Merged
sithlord48 merged 2 commits into
masterfrom
no-short-key-len
Jun 16, 2025
Merged

chore: Remove 1024 TLS key length option#8671
sithlord48 merged 2 commits into
masterfrom
no-short-key-len

Conversation

@nbolton

@nbolton nbolton commented Jun 10, 2025

Copy link
Copy Markdown
Member

Fixes: #8670
Updated by sithlord48

  • Remove 1024bit as an option when generating new keys
  • Enforce a minimum key size of 2048-bit
  • Users with keys smaller then 2048 (who have TLS enabled)
    • Are informed the key size it too small
    • Have their keys regenerated with a size of 2048-bit
    • Sets the KeySize Settings to 2048

Todo:

  • Test

@sithlord48

Copy link
Copy Markdown
Member

@nbolton I updated this and i think its ready now.

@nbolton nbolton left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sithlord48 LGTM, are you able to approve or does it need to be forced in now you made changes?

@nbolton
nbolton marked this pull request as ready for review June 16, 2025 08:52
@nbolton
nbolton force-pushed the no-short-key-len branch from 8e5b9c6 to 7ea4072 Compare June 16, 2025 09:17
@nbolton
nbolton enabled auto-merge (rebase) June 16, 2025 09:17
@sithlord48

sithlord48 commented Jun 16, 2025

Copy link
Copy Markdown
Member

@nbolton yeah i may need your approval to land.

@sithlord48
sithlord48 disabled auto-merge June 16, 2025 12:02
@sithlord48
sithlord48 merged commit 04943fa into master Jun 16, 2025
@sithlord48
sithlord48 deleted the no-short-key-len branch June 16, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error using small TLS key (1024)

2 participants