Messages improve - #8661
Merged
Merged
Conversation
construct QString without concat return aftershowing fatal error dialog Enable Translation for user facing strings
use app name for title create message using append enable translations
add app name to dialog title
enable translations
add the app name into the title
use QString::append to add to the string
enable translations
slight reword for Already Connected error use QString::append to add to the message create a QMessageBox::warning style box for these errors enable translations
…enable translations
nbolton
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic improvements to
deskflow::gui::messages