Skip to content

fix: ServerConfigDialog disabled spinboxes that should be enabled on open - #8644

Merged
nbolton merged 1 commit into
masterfrom
fixDisabledSpinboxesinServerConfig
Jun 2, 2025
Merged

fix: ServerConfigDialog disabled spinboxes that should be enabled on open#8644
nbolton merged 1 commit into
masterfrom
fixDisabledSpinboxesinServerConfig

Conversation

@sithlord48

@sithlord48 sithlord48 commented Jun 1, 2025

Copy link
Copy Markdown
Member

Fix an locked controls in ServerConfigDialog when the parent control is enabled

The following were disabled when the controlling option was enabled on the dialog being opened

  • sbHeartbeat
  • sbSwitchDelay
  • sbSwitchDoubleTap
  • External Config Controls (also disable other tabs if enabled)

…nd on another option being enabled example being the heatbeat spinbox if heatbeat is enabled
@sithlord48
sithlord48 requested a review from nbolton June 1, 2025 16:46
@sithlord48 sithlord48 added this to the v1.23.0 milestone Jun 1, 2025
@sithlord48 sithlord48 added ⛏️ nit This is a nit, a minor but bothersome concern 🩹 fix This PR fixes a reported bug and removed 🩹 fix This PR fixes a reported bug labels Jun 1, 2025

@nbolton nbolton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@nbolton
nbolton merged commit 7e4d43f into master Jun 2, 2025
@nbolton
nbolton deleted the fixDisabledSpinboxesinServerConfig branch June 2, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⛏️ nit This is a nit, a minor but bothersome concern

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants