Feat: Define QT_NO_KEYWORDS, allowing us to use Qt in more places - #8638
Merged
Conversation
Closed
sithlord48
added
the
🗒️ task
nbolton
requested changes
Jun 2, 2025
Member
Author
|
Edit: Added a commit to remove those includes. |
nbolton
approved these changes
Jun 2, 2025
sithlord48
enabled auto-merge (rebase)
June 2, 2025 20:52
must use Q_SIGNALS, Q_SLOTS and Q_EMIT in place of signals, slots and emit macros
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines QT_NO_KEYWORDS preventing issues w/
signalsbeing defined by both Qt and GTK ( used in libportal)Q_SIGNALS,Q_SLOTSandQ_EMITin place of signals, slots and emit macrosFixed include order in AppUtilUnix causing X11 to be pulled in before our local code causing issue when building with Qt
Tested locally by added QString to the Constants.h.in file
Document in wiki the requirement for
Q_SIGNALSQ_SLOTSandQ_EMIT