IL backport: Cleanup Error handling - #8623
Merged
Merged
Conversation
sithlord48
changed the title
sithlord48
force-pushed
the
il_port_1544
branch
5 times, most recently
from
May 25, 2025 06:15
5f3c849 to
60833a0
Compare
sithlord48
marked this pull request as ready for review
May 25, 2025 06:17
nbolton
requested changes
May 28, 2025
This functionality is not needed because in all code paths the error code is immediately converted to string without actually using the lazy evaluation functionality. based-on: input-leap/input-leap@53dff5b ported and expanded by sithlord48
ported from: input-leap/input-leap@1f3cd0d ported-by sithlord48
This is needed because by convention exceptions must derive from at least std::exception. ported from: input-leap/input-leap@22aec16 ported-by sithlord48
XArch no longer contains any extra functionality in addition to what std::runtime_error nor it signifies a particular type of error. based-on: input-leap/input-leap@5b99169 ported-by: sithlord48
nbolton
reviewed
May 28, 2025
nbolton
left a comment
nbolton
left a comment
Member
There was a problem hiding this comment.
Damn, I wrote this comment at the same time as the other review but it didn't get shared.
nbolton
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport: input-leap/input-leap#1544
used --author to make sure the author @p12tic gets credit.
expanded a few places to cover code not in input-leap