Skip to content

Sonar cleanup 4 - #8619

Merged
nbolton merged 8 commits into
masterfrom
sonarCleanup_4
May 28, 2025
Merged

Sonar cleanup 4#8619
nbolton merged 8 commits into
masterfrom
sonarCleanup_4

Conversation

@sithlord48

@sithlord48 sithlord48 commented May 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  • Use final in some subclasses
  • Remove virtual from some un subclassed methods
  • ActionDialog, remove empty statement
  • SecureUtils, do not use final for string Var name
  • static_cast to replace reinterpret_cast where possible
  • Combine unnessessary multi level if into less fewer checks
  • use const for more local ref and pointer vars
  • even more const methods
  • catch up some the windows classes

@sithlord48
sithlord48 marked this pull request as ready for review May 23, 2025 19:45
@sithlord48
sithlord48 requested a review from nbolton May 23, 2025 19:45
@sithlord48
sithlord48 force-pushed the sonarCleanup_4 branch 3 times, most recently from a2490db to a8bfe9f Compare May 24, 2025 00:09
@sithlord48
sithlord48 force-pushed the sonarCleanup_4 branch 6 times, most recently from 3e01ebb to 8a76530 Compare May 24, 2025 16:54
@sithlord48 sithlord48 added this to the v1.22.0 milestone May 27, 2025
@nbolton
nbolton merged commit 9eabbb6 into master May 28, 2025
@nbolton
nbolton deleted the sonarCleanup_4 branch May 28, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.22.0

Development

Successfully merging this pull request may close these issues.

2 participants

@sithlord48 @nbolton