Consolidate arch strings - #8617
Merged
Merged
Conversation
sithlord48
commented
May 22, 2025
sithlord48
commented
Member
- Clean up remaining IArchString smells
- Make IArchString::EWideCharEncoding an enum class
- Combine IArchString and it's subclasses into one ArchString class
sithlord48
added
the
🗒️ task
Merged
sithlord48
force-pushed
the
consolidateArchStrings
branch
3 times, most recently
from
May 23, 2025 02:13
2f6751c to
8e59df1
Compare
sithlord48
force-pushed
the
consolidateArchStrings
branch
from
May 23, 2025 16:48
8e59df1 to
a8c88a3
Compare
nbolton
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.