Skip to content

Sonar cleanup 3 - #8616

Merged
sithlord48 merged 6 commits into
masterfrom
sonarCleanup_3
May 23, 2025
Merged

Sonar cleanup 3#8616
sithlord48 merged 6 commits into
masterfrom
sonarCleanup_3

Conversation

@sithlord48

@sithlord48 sithlord48 commented May 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Requires: #8617

  • SettingsDialog rename ui_ => ui
  • correct missed synergy::gui to deskflow::gui
  • Prefer to Initiliaze class vars in class define then initializer list
  • use a const Ref for ServerConnection client name check
  • refactor server/Config to use the variable initializer and condition part of the for loop when checking for a valid name
  • use ranged for in ClientListener::cleanupClientSockets

@sithlord48
sithlord48 force-pushed the sonarCleanup_3 branch 11 times, most recently from 8657b8c to 968410d Compare May 23, 2025 05:19
@sithlord48 sithlord48 added the 🗒️ task Doesn't directly add new functionality or fix bugs in the program label May 23, 2025
@sithlord48
sithlord48 marked this pull request as ready for review May 23, 2025 12:44
@sithlord48
sithlord48 requested a review from nbolton May 23, 2025 12:44
nbolton
nbolton reviewed May 23, 2025
View reviewed changes
Comment thread src/lib/server/Config.cpp
@nbolton
nbolton enabled auto-merge (rebase) May 23, 2025 16:45
@sithlord48
sithlord48 disabled auto-merge May 23, 2025 16:54
@sithlord48
sithlord48 enabled auto-merge (rebase) May 23, 2025 17:01
@sithlord48
sithlord48 merged commit a4f1a38 into master May 23, 2025
@sithlord48
sithlord48 deleted the sonarCleanup_3 branch May 23, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes

Assignees

No one assigned

Labels

🗒️ task Doesn't directly add new functionality or fix bugs in the program

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sithlord48 @nbolton