Remove Ifdef around iso_level5 - #8612
Merged
Merged
Conversation
nbolton
reviewed
May 22, 2025
Member
There was a problem hiding this comment.
Why was this guarded ?
No idea. Will test tomorrow.
Edit: It seems I applied a patch 12 years ago in 2012 by Jim Hague: 6dcefaf
patch: for "old" unix, fixed compile problems (missing xi2 stuff), and refactored header tests (thanks to Jim Hague)
I must have missed the #ifdef XK_ISO_Level5_Shift line as it's basically the same as doing #ifdef 0 since XK_ISO_Level5_Shift was never defined. Looks like an accident.
I wonder what else I missed in that patch.
nbolton
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why was this guarded ?
related #3259 to the latest comments ?