Sonar cleanup 2 - #8610
Merged
Merged
Conversation
sithlord48
force-pushed
the
sonarCleanup_2
branch
12 times, most recently
from
May 22, 2025 03:45
9a4f9dc to
a90a576
Compare
sithlord48
marked this pull request as ready for review
May 22, 2025 04:06
…use RETRY_TIME directly in ClientApp instead
sithlord48
force-pushed
the
sonarCleanup_2
branch
from
May 22, 2025 16:54
a90a576 to
541fea6
Compare
nbolton
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventQueuestd::string_viewwere its possible//from comment blocksRETRY_TIMEdirectly inClientApp, remove unused old methods around itemplace_backin modified code