Skip to content

More Sonar cleanup - #8607

Merged
nbolton merged 7 commits into
masterfrom
sonarCleanup_1
May 20, 2025
Merged

More Sonar cleanup#8607
nbolton merged 7 commits into
masterfrom
sonarCleanup_1

Conversation

@sithlord48

@sithlord48 sithlord48 commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Fix more sonar issues

  • Daemon and subclasses should pass const & func
  • Use C++17 style if / switch initilizers where we can
  • more Const methods
  • start to use even more auto / const auto
  • replace use of typedef with using
  • minor typo fix from colom to colon
  • Define only one var per line
  • Add more // do nothing for empty methods.

@sithlord48
sithlord48 requested a review from nbolton May 20, 2025 11:56
@sithlord48
sithlord48 marked this pull request as draft May 20, 2025 14:14
nbolton
nbolton previously approved these changes May 20, 2025
View reviewed changes
Comment thread src/lib/platform/EiScreen.cpp Outdated
Comment thread src/lib/platform/EiScreen.cpp
sithlord48 added 3 commits May 20, 2025 10:40
@sithlord48
chore: cleansmells in ArchDaemon
1f7f1a4
@sithlord48
chore: replace typedef with using
1416753
@sithlord48
chore: use c++17 style if,switch init-initilizer where possible
5490cf9 
chore: correct spelling of "colon" in NetworkAddresses variables
chore: correct some multi line defines near needed init-initilizers
@sithlord48
sithlord48 marked this pull request as ready for review May 20, 2025 14:42
@sithlord48
sithlord48 requested a review from nbolton May 20, 2025 14:43
@nbolton
nbolton merged commit 3cf0fb8 into master May 20, 2025
@nbolton
nbolton deleted the sonarCleanup_1 branch May 20, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sithlord48 @nbolton