fix: lockup if first run message is up and a client connects - #8601
Merged
Conversation
Member
|
How do I reproduce the bug that this fixes? What are the steps? I solved #8599 with my PR. On
I was unable to get the GUI to freeze on master. I guess if it's a race condition then maybe I'm just not being unlucky enough. Have you seen a GUI freeze since my PR landed? My rationale: I don't want to land a "just in case" PR unless I can prove it solves a bug. |
Member
Author
|
added steps above |
Member
sithlord48
force-pushed
the
fixCoreProcessSignals
branch
from
May 19, 2025 20:36
5fffcd8 to
1b710c4
Compare
Member
Author
|
you need to accept the client dialog and add the screen to see the freeze. |
Member
Member
|
Are you sure you're still able to repro this on |
sithlord48
force-pushed
the
fixCoreProcessSignals
branch
from
May 19, 2025 20:59
1b710c4 to
73c721c
Compare
sithlord48
force-pushed
the
fixCoreProcessSignals
branch
from
May 19, 2025 21:54
73c721c to
17f0049
Compare
Member
Author
|
100% of the time ( video below is current master ) 2025-05-19.18-05-30.mp4 |
Member
nbolton
approved these changes
May 20, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fix a possible crash if the first server run dialog is up when a new client and the fingerprint is dealt with and screen added the app would freeze w/ the first server run dialog showing.. (this allows you to close it)
shown in #8599