fix: Disable the save button when config not writable - #8592
Merged
Conversation
nbolton
marked this pull request as ready for review
May 15, 2025 16:37
Member
Author
|
I noticed if I make the file read only, then only the preferences are shown as read only. I do wonder if we can simplify all of this by showing an error on save or even on load if the settings are read only:
|
sithlord48
requested changes
May 15, 2025
nbolton
force-pushed
the
ro-disable-save
branch
2 times, most recently
from
May 19, 2025 20:20
aed4cd8 to
fe892c6
Compare
nbolton
enabled auto-merge (rebase)
May 19, 2025 20:46
sithlord48
force-pushed
the
ro-disable-save
branch
from
May 19, 2025 21:00
8172fe5 to
9f78249
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo: