Skip to content

Fix code smells in GUI - #8580

Merged
nbolton merged 14 commits into
deskflow:masterfrom
tcanabrava:tcanabrava/improve_codebase
May 9, 2025
Merged

Fix code smells in GUI#8580
nbolton merged 14 commits into
deskflow:masterfrom
tcanabrava:tcanabrava/improve_codebase

Conversation

@tcanabrava

@tcanabrava tcanabrava commented May 8, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@sithlord48

sithlord48 commented May 8, 2025

Copy link
Copy Markdown
Member

Can you fix them to use our style https://github.com/deskflow/deskflow/wiki/Hacking-Guide
Ill check the code asap.

@github-actions

This comment was marked as outdated.

Sign in to view
@nbolton nbolton changed the title Tcanabrava/improve codebase Fix code smells in GUI May 8, 2025
nbolton
nbolton reviewed May 8, 2025
View reviewed changes
Comment thread src/lib/gui/MainWindow.cpp Outdated
@sithlord48
sithlord48 force-pushed the tcanabrava/improve_codebase branch 3 times, most recently from e6128ac to 3995c6b Compare May 8, 2025 14:07
tcanabrava added 14 commits May 8, 2025 10:29
@sithlord48
sithlord48 force-pushed the tcanabrava/improve_codebase branch from 3995c6b to 6295492 Compare May 8, 2025 14:29
sithlord48
sithlord48 approved these changes May 8, 2025
View reviewed changes

@sithlord48 sithlord48 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
@nbolton any idea what those methods that were not used in mainwindow were for ?

@tcanabrava

tcanabrava commented May 8, 2025

Copy link
Copy Markdown
Contributor Author

Looks good to me @nbolton any idea what those methods that were not used in mainwindow were for ?

Probably leftovers of removed code. Since compilers don't complain about unimplemented methods, they just stuck for years.

@sithlord48

sithlord48 commented May 8, 2025

Copy link
Copy Markdown
Member

Looks good to me @nbolton any idea what those methods that were not used in mainwindow were for ?

Probably leftovers of removed code. Since compilers don't complain about unimplemented methods, they just stuck for years.

Well yeah but what were they for when they were implemented. (i.e do we need to implement them again )

nbolton
nbolton approved these changes May 9, 2025
View reviewed changes

@nbolton nbolton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, ETIME, but LGTM

@nbolton
nbolton merged commit af383de into deskflow:master May 9, 2025
@sithlord48 sithlord48 mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes
@sithlord48 sithlord48 sithlord48 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tcanabrava @sithlord48 @nbolton