Skip to content

Remove drag and drop support - #8569

Merged
sithlord48 merged 1 commit into
masterfrom
rmDragandDrop
May 8, 2025
Merged

Remove drag and drop support#8569
sithlord48 merged 1 commit into
masterfrom
rmDragandDrop

Conversation

@sithlord48

@sithlord48 sithlord48 commented May 5, 2025

Copy link
Copy Markdown
Member

fixes: #8459

  • Remove Drag and Drop
  • Rename OSXDragSimulator => OSXCocoaApp
    • Keep the parts to start / stop the cocoa app (needed for client / server to work)
    • Remove the parts related to DnD

Tested:

  • Linux host (wayland)
  • Linux client (wayland)
  • Linux host (X)
  • Linux client (X)
  • Windows host
  • Windows client
  • Mac host
  • Mac client

@sithlord48
sithlord48 force-pushed the rmDragandDrop branch 5 times, most recently from ddcfe45 to ecbc174 Compare May 5, 2025 03:18
@sithlord48
sithlord48 marked this pull request as ready for review May 5, 2025 03:27
@sithlord48
sithlord48 requested a review from nbolton May 5, 2025 03:27
@sithlord48
sithlord48 marked this pull request as draft May 5, 2025 13:55
@nbolton nbolton mentioned this pull request May 5, 2025
@sithlord48
sithlord48 force-pushed the rmDragandDrop branch 9 times, most recently from f2ee0a3 to 02f5683 Compare May 8, 2025 01:04
@sithlord48
sithlord48 marked this pull request as ready for review May 8, 2025 01:05
@sithlord48 sithlord48 self-assigned this May 8, 2025
@sithlord48 sithlord48 modified the milestone: v1.22.0 May 8, 2025
@nbolton

nbolton commented May 8, 2025

Copy link
Copy Markdown
Member

Tested and working:

  • macOS host
  • macOS client
  • Windows host
  • Windows client
  • Linux host
  • Linux client

nbolton
nbolton previously approved these changes May 8, 2025

@nbolton nbolton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to land as it's working but maybe we can reduce src/lib/platform/OSXCocoaApp.m or remove it entirely...

Comment thread src/lib/platform/OSXCocoaApp.m
Comment thread src/lib/platform/OSXCocoaApp.m Outdated
nbolton
nbolton previously approved these changes May 8, 2025
Comment thread src/lib/platform/OSXCocoaApp.m Outdated
@sithlord48
sithlord48 enabled auto-merge (rebase) May 8, 2025 12:31
@sithlord48
sithlord48 requested a review from nbolton May 8, 2025 12:32
@sithlord48
sithlord48 merged commit 5365e34 into master May 8, 2025
@sithlord48
sithlord48 deleted the rmDragandDrop branch May 8, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove drag and drop

2 participants