Better detect windows Arm64 on both CI and local builds - #8567
Merged
Conversation
sithlord48
force-pushed
the
fixupARM64windetect
branch
from
May 3, 2025 01:37
6810d6e to
c68632c
Compare
sithlord48
changed the title
nbolton
reviewed
May 3, 2025
sithlord48
force-pushed
the
fixupARM64windetect
branch
from
May 3, 2025 23:29
c68632c to
808b9db
Compare
nbolton
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing locally with win arm64 the detection was incorrect. I have adjusted the check to look for the CI's ENV var then try to use the CMAKE_SYSTEM_PROCESSOR when detecting the cpu type on windows