Tidy up macos code smells missed by sonarscan - #8566
Merged
Conversation
sithlord48
added
🍎 mac
sithlord48
changed the title
sithlord48
force-pushed
the
sonarCleanup_MacCatchup
branch
6 times, most recently
from
May 2, 2025 21:22
ca79c84 to
71fb4cf
Compare
sithlord48
marked this pull request as ready for review
May 2, 2025 21:59
sithlord48
added
🍎 mac
nbolton
approved these changes
May 3, 2025
nbolton
force-pushed
the
sonarCleanup_MacCatchup
branch
from
May 3, 2025 20:14
71fb4cf to
a4e74c0
Compare
nbolton
enabled auto-merge (rebase)
May 3, 2025 20:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to #8564 get
overrideand use of default constructors / deconstructors