Tidy up windows code smells missed by sonarscan - #8564
Merged
Conversation
sithlord48
force-pushed
the
sonarCleanup_WinCatchup
branch
4 times, most recently
from
May 2, 2025 18:22
352b1d3 to
ab0cc6b
Compare
sithlord48
added
🪟 windows
sithlord48
force-pushed
the
sonarCleanup_WinCatchup
branch
3 times, most recently
from
May 2, 2025 19:46
ad9738e to
ac48e8e
Compare
sithlord48
changed the title
nbolton
approved these changes
May 3, 2025
nbolton
force-pushed
the
sonarCleanup_WinCatchup
branch
from
May 3, 2025 20:12
ac48e8e to
416c770
Compare
Member
|
Ignoring:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires: #8565
Try to catch the windows specific files by using
overrideand default constructors / deconstructs where possibleComical that sonar scan would detect subclasses as duplicated code...
