Conversation
sithlord48
force-pushed
the
fix_8534
branch
2 times, most recently
from
April 24, 2025 01:36
dc42c92 to
830e180
Compare
Member
Author
|
@jonathan-mcewan can you test this when its finished building and report back if it worked. (it did in my local test) Direct link to the win artifacts for the job: https://github.com/deskflow/deskflow/actions/runs/14631534694/artifacts/2998593238 |
Member
Want to wait for this before landing? |
Member
|
Wayland server seems borken in this PR. Edit: Clients connect and I don't see any errors, but weirdly the portal permission dialog doesn't show. I wonder if this happens because we're creating a Qt app instance in server? // HACK to make sure settings gets the correct qApp path
QCoreApplication m(argc, argv);
m.deleteLater();Maybe GNOME specific? I'll also test KDE. Edit: Heh... KDE Wayland client also not working; no portal dialog on KDE Wayland client. Server: |
Member
Author
|
Do you think its safe to just guard this on windows only ? (until we make them QCoreApplication) |
…ind the app path with fixes #8534
Member
Ah yeah maybe; I think it only had an adverse effect on Wayland. Though it doesn't bode well for us wanting to Qt-ize the core :| |
Member
Author
Naw should be fine when we are using them and not the rando app w/ run . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8534
deskflow-server,deskflow-coreanddeskflow-clientare not QApplications this causes the qApp used in our settings object to fallback to the default path and make the settings read from different paths (if not using the default one)To Fix this on windows only we make a QCoreApplication in each of them and delete it after , this is enough to initialize the qApp.
We should consider in the future making these apps use a QCoreApplication in place of the
App