build: Replace CMAKE_SYSTEM_PROCESSOR with BUILD_ARCHITECTURE - #8524
Merged
Conversation
nbolton
force-pushed
the
betterArchDetection
branch
from
April 23, 2025 09:01
b96847f to
7be3bc6
Compare
nbolton
approved these changes
Apr 23, 2025
nbolton
requested changes
Apr 23, 2025
sithlord48
force-pushed
the
betterArchDetection
branch
from
April 23, 2025 11:25
7be3bc6 to
c04817c
Compare
…dows CMAKE_SYSTEM_PROCESSOR is flawed so when possible use the vcpkg info or default to x64 Adjust the vcruntime check to use the BUILD_ARCHITECTURE to check the proper version is installed for the architecture the app is build for
sithlord48
force-pushed
the
betterArchDetection
branch
from
April 23, 2025 11:50
c04817c to
7f0d792
Compare
nbolton
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On windows CMAKE_SYSTEM_PROCESSOR is flawed so when possible use the vcpkg info on windows or default to x64
Adjust the vcruntime check to use the BUILD_ARCHITECTURE to check the proper version is installed for the architecture the app is build for