Skip to content

fix: Show first server start message only when start was successful - #8467

Merged
sithlord48 merged 1 commit into
masterfrom
fix-server-start-message
Apr 9, 2025
Merged

fix: Show first server start message only when start was successful#8467
sithlord48 merged 1 commit into
masterfrom
fix-server-start-message

Conversation

@nbolton

@nbolton nbolton commented Apr 9, 2025

Copy link
Copy Markdown
Member

The server start success message was always showing whether or not the core start worked.

@nbolton
nbolton force-pushed the fix-server-start-message branch from 35394b7 to 100e8e8 Compare April 9, 2025 11:12
@nbolton
nbolton requested a review from sithlord48 April 9, 2025 11:13
@nbolton
nbolton marked this pull request as draft April 9, 2025 11:22
@nbolton
nbolton removed the request for review from sithlord48 April 9, 2025 11:22
@nbolton

nbolton commented Apr 9, 2025

Copy link
Copy Markdown
Member Author

Something isn't working as I expected, setting to draft until I figure it out.

Edit: Never mind.

Weird error on macOS CI:

[ 58%] Linking CXX executable ../../../bin/Deskflow.app/Contents/MacOS/deskflow-server
ld: warning: ignoring duplicate libraries: '-lpthread', '../../lib/arch/libarch.a', '../../lib/base/libbase.a', '../../lib/client/libclient.a', '../../lib/deskflow/libapp.a', '../../lib/io/libio.a', '../../lib/mt/libmt.a', '../../lib/net/libnet.a', '../../lib/platform/libplatform.a', '../../lib/server/libserver.a'
[ 59%] Linking CXX executable ../../../bin/Deskflow.app/Contents/MacOS/deskflow-client
ld: library 'pthread' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [bin/Deskflow.app/Contents/MacOS/deskflow-server] Error 1
make[1]: *** [src/apps/deskflow-server/CMakeFiles/deskflow-server.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
ld: warning: ignoring duplicate libraries: '-lpthread', '../../lib/arch/libarch.a', '../../lib/base/libbase.a', '../../lib/client/libclient.a', '../../lib/deskflow/libapp.a', '../../lib/io/libio.a', '../../lib/mt/libmt.a', '../../lib/net/libnet.a', '../../lib/platform/libplatform.a', '../../lib/server/libserver.a'
ld: library 'pthread' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [bin/Deskflow.app/Contents/MacOS/deskflow-client] Error 1
make[1]: *** [src/apps/deskflow-client/CMakeFiles/deskflow-client.dir/all] Error 2
[ 59%] Built target gui_autogen
make: *** [all] Error 2

@nbolton
nbolton requested a review from sithlord48 April 9, 2025 11:26
@nbolton
nbolton marked this pull request as ready for review April 9, 2025 11:26
@sithlord48

Copy link
Copy Markdown
Member

Yeah mac os 13 refuses to find pthread now.. just started happing last night...

@nbolton
nbolton force-pushed the fix-server-start-message branch from 100e8e8 to 614f6ce Compare April 9, 2025 12:53
@sithlord48
sithlord48 merged commit 16ef088 into master Apr 9, 2025
@sithlord48
sithlord48 deleted the fix-server-start-message branch April 9, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants