fix: Show first server start message only when start was successful - #8467
Merged
Conversation
nbolton
force-pushed
the
fix-server-start-message
branch
from
April 9, 2025 11:12
35394b7 to
100e8e8
Compare
nbolton
marked this pull request as draft
April 9, 2025 11:22
Member
Author
|
Edit: Never mind. Weird error on macOS CI: |
nbolton
marked this pull request as ready for review
April 9, 2025 11:26
Member
|
Yeah mac os 13 refuses to find pthread now.. just started happing last night... |
nbolton
force-pushed
the
fix-server-start-message
branch
from
April 9, 2025 12:53
100e8e8 to
614f6ce
Compare
sithlord48
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server start success message was always showing whether or not the core start worked.