Skip to content

feat: add help and version to gui, - #8442

Merged
sithlord48 merged 6 commits into
masterfrom
gui-commanlineParser
Apr 6, 2025
Merged

feat: add help and version to gui,#8442
sithlord48 merged 6 commits into
masterfrom
gui-commanlineParser

Conversation

@sithlord48

@sithlord48 sithlord48 commented Apr 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  • Requires Manpages #8440
  • Change app description from Mouse and keyboard sharing utility => Keyboard and mouse sharing utility

Clean up some unused item in deskflow-gui.cpp

  • Remove unused headers
  • Remove unused QThreadImpl class
  • Remove workaround for Qt-40332
  • Remove fallback for pre mavericks accessibility dialog

Add Cli options

  • Removes the need for the template man page for deskflow's gui
  • move --no-reset to the QCommandLineProcessor
  • add --help 
       Deskflow: 1.21.1.18 (f41b6a45)
     Keyboard and mouse sharing utility

   Usage: deskflow [options]

   Options:
     --help      Display Help on the command line
     --version   Display version information
     --no-reset  Prevent settings reset if DESKFLOW_RESET_ALL is set
  • add --version 
        Deskflow: 1.21.1.18 (f41b6a45)
    Copyright (C) 2024-2025 Deskflow Devs
    Copyright (C) 2012-2025 Symless Ltd.
    Copyright (C) 2009-2012 Nick Bolton
    Copyright (C) 2002-2009 Chris Schoeneman

@sithlord48
sithlord48 requested a review from nbolton April 3, 2025 22:36
@sithlord48 sithlord48 mentioned this pull request Apr 3, 2025
Merged
@sithlord48
sithlord48 marked this pull request as draft April 4, 2025 00:50
@sithlord48
sithlord48 force-pushed the gui-commanlineParser branch 3 times, most recently from 57ea0e0 to 88b112e Compare April 4, 2025 02:13
@sithlord48
sithlord48 marked this pull request as ready for review April 4, 2025 02:16
@sithlord48
sithlord48 marked this pull request as draft April 4, 2025 02:31
@sithlord48
sithlord48 force-pushed the gui-commanlineParser branch 7 times, most recently from a46f0f1 to c0ae1c2 Compare April 4, 2025 13:41
@sithlord48 sithlord48 self-assigned this Apr 4, 2025
@sithlord48
sithlord48 force-pushed the gui-commanlineParser branch from c0ae1c2 to 512fcd2 Compare April 4, 2025 13:58
@sithlord48
sithlord48 marked this pull request as ready for review April 4, 2025 13:59
@sithlord48
sithlord48 force-pushed the gui-commanlineParser branch from 512fcd2 to 6b1a7d5 Compare April 5, 2025 20:30
nbolton
nbolton previously approved these changes Apr 6, 2025
View reviewed changes
Comment thread src/apps/deskflow-gui/deskflow-gui.cpp Outdated
@sithlord48
sithlord48 force-pushed the gui-commanlineParser branch from 6b1a7d5 to 8c9154c Compare April 6, 2025 13:32
@sithlord48
sithlord48 enabled auto-merge (rebase) April 6, 2025 13:32
@sithlord48
sithlord48 merged commit 1ace03d into master Apr 6, 2025
@sithlord48
sithlord48 deleted the gui-commanlineParser branch April 6, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbolton nbolton nbolton approved these changes

Assignees

@sithlord48 sithlord48

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sithlord48 @nbolton