Settings service update - #8439
Conversation
sithlord48
added
✨ enhancement
I'm wondering if we need this [setting] at all. I'll do some testing but after thinking about this over the last few days, I suspect it might be redundant now that we're not elevating as needed. IIRC, I added it to kill the process so it could auto switch between being elevated or not. If we're making elevation manual and removing the auto switch (which I think we should) then, I think there should be no reason for the core to die when the desk switches... I could be totally wrong though so let me do some experimenting/digging. |
|
Sounds good lmk and i will remove it we don't need it |
d2377cb to
bfd704c
Compare
bfd704c to
fbc9168
Compare
nbolton
left a comment
nbolton
left a comment
There was a problem hiding this comment.
TL;DR: We could land this but the checkbox wording and behavior should change. If we keep the hacky 'stop on desk switch' behavior then we need to explain how it works and that it will still elevate the process (as needed) if selected.
Removing it is an option but this will create dead code that we should remove, possibly in a new PR. The code we'd need to remove would be in the watchdog:
It's one of those... 'clever but stupid' features.
fbc9168 to
b992386
Compare
… and use Daemon::Elevate to hold the value
b992386 to
93aaee2
Compare
|
FTR, we decided to remove the |
2 participants
fixes: #8350
Settings::Core::ElevateModeand setsDaemon::ElevateInstead (default: true)Settings::Core::StopOnDeskSwitch(default: false)You can only select one of the option