Skip to content

fixes #8423, set unit test to force external config on for server tests - #8436

Merged
nbolton merged 1 commit into
masterfrom
fix_8423
Apr 2, 2025
Merged

fixes #8423, set unit test to force external config on for server tests#8436
nbolton merged 1 commit into
masterfrom
fix_8423

Conversation

@sithlord48

Copy link
Copy Markdown
Member

@anthraxx

anthraxx commented Apr 1, 2025

Copy link
Copy Markdown

This seems to fix the issue for the arch repo builds as well. With this patch applied, we correctly skip the tests now:

[----------] 4 tests from ServerConnectionTests
[ RUN      ] ServerConnectionTests.handleLogLine_newClient_shouldShowPrompt
external config enabled, skipping new client prompt
[       OK ] ServerConnectionTests.handleLogLine_newClient_shouldShowPrompt (0 ms)
[ RUN      ] ServerConnectionTests.handleLogLine_ignoredClient_shouldNotShowPrompt
external config enabled, skipping new client prompt
external config enabled, skipping new client prompt
[       OK ] ServerConnectionTests.handleLogLine_ignoredClient_shouldNotShowPrompt (0 ms)
[ RUN      ] ServerConnectionTests.handleLogLine_serverConfigFull_shouldNotShowPrompt
external config enabled, skipping new client prompt
[       OK ] ServerConnectionTests.handleLogLine_serverConfigFull_shouldNotShowPrompt (0 ms)
[ RUN      ] ServerConnectionTests.handleLogLine_screenExists_shouldNotShowPrompt
external config enabled, skipping new client prompt
[       OK ] ServerConnectionTests.handleLogLine_screenExists_shouldNotShowPrompt (0 ms)
[----------] 4 tests from ServerConnectionTests (0 ms total)

@sithlord48
sithlord48 requested a review from nbolton April 1, 2025 22:57
@sithlord48 sithlord48 modified the milestone: v1.21.2 Apr 1, 2025
@sithlord48 sithlord48 added the 🩹 fix This PR fixes a reported bug label Apr 2, 2025
@nbolton
nbolton merged commit 6bbebe7 into master Apr 2, 2025
@nbolton
nbolton deleted the fix_8423 branch April 2, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🩹 fix This PR fixes a reported bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AUR Builds are Failing

3 participants