refactor: settings for windows by sithlord48 · Pull Request #8428 · deskflow/deskflow

sithlord48 · 2025-03-31T17:40:52Z

fixes: #8429
fixes: #8432
fixes: #8434

On windows use the registry to save the items normally in Deskflow.conf
On windows use the registry unless the portableSettings file [install-dir]/settings/Deskflow.conf if found
- On Windows Use either ProgramData\Deskflow to save tls and other non "settings" when registry is in use
- On Windows Use either [installdir]/settings to save tls and other non "settings" when registry is not in use
Set the default process Type based on the kind of settings loaded
- InI Format (unix / mac / windows portable) the mode defaults to Desktop
- Native Format settings (only windows installed mode) we default to Service
Set the default elevation mode based on type also
- InI Format (unix / mac / windows portable) the mode defaults to Never
- Native Format settings (only windows installed mode) we default to Always
Hide the service section when its not able to be used
Daemon log is always saved in the install dir
Make sure if using portable settings the a new empty file is created if settings are cleared.

Windows artifact to test with is here generated via latest build of this pr

sithlord48 · 2025-04-01T00:20:24Z

That seams like the wrong version to me if you check click on the hash its another PR..
Edit sorry @robot3498712 it seams i linked the wrong build in that pr ill fix that comment and also link in the pr description

robot3498712 · 2025-04-01T00:56:02Z

Thanks! That seems to have done it.
Automatic (as needed): check
Always: check

(I had to manually restart the deskflow service.)

Deskflow: 1.21.1.7 (b218535)
Qt: 6.8.2
System: Windows 10 Version 22H2

sithlord48 · 2025-04-01T01:00:33Z

yeah the service is a bit odd on reinstall sometimes.

nbolton

Quick review. I will test this shortly.

nbolton

Strange. I managed to get the daemon to freeze up by setting elevate mode to 'As needed' then running an elevated process to show UAC. The client didn't re-launch and the daemon became unresponsive. I then saw an IPC error. Clicking 'Apply' in the GUI seemed to un-freeze it, but after trying a 2nd time I wasn't able to repro.

Edit: This was on a fresh VM.

I noticed you made 'Always elevate' the default which will certainly make things simpler. At this point I'm think we just need to get rid of the 'As needed' option (maybe in a separate PR).

#8350

…stall new Settings::isUsingRegistry() true when using the registry move daemon log back to config dir

…NI Type we in desktop mode if Native (only on windows) we default to Service

…r registry we use Always, ini mode uses Never

…e is created

sithlord48 force-pushed the windowsBetterSettings branch from 23512b4 to b12d515 Compare March 31, 2025 17:44

sithlord48 mentioned this pull request Mar 31, 2025

Core on Windows is elevated after logging in when 'As needed' is selected #8345

Closed

6 tasks

sithlord48 force-pushed the windowsBetterSettings branch 4 times, most recently from d57a137 to 2218596 Compare March 31, 2025 18:34

sithlord48 self-assigned this Mar 31, 2025

sithlord48 requested a review from nbolton March 31, 2025 18:39

sithlord48 marked this pull request as ready for review March 31, 2025 18:39

sithlord48 force-pushed the windowsBetterSettings branch 2 times, most recently from 40da9ee to 42d8862 Compare March 31, 2025 20:06

sithlord48 marked this pull request as draft March 31, 2025 21:22

sithlord48 marked this pull request as ready for review March 31, 2025 21:32

sithlord48 marked this pull request as draft March 31, 2025 22:55

sithlord48 force-pushed the windowsBetterSettings branch from 42d8862 to 9e2974b Compare March 31, 2025 23:55

This comment was marked as resolved.

Sign in to view

sithlord48 force-pushed the windowsBetterSettings branch 2 times, most recently from 28a06e5 to 24cfc73 Compare April 1, 2025 00:11

sithlord48 marked this pull request as ready for review April 1, 2025 00:17

This was referenced Apr 1, 2025

After the update, the connection fails. When the msi installation package of deskflow is opened, the mouse jumps back to the server #8429

Closed

Continuous build TLS issues broke on stable #8432

Closed

nbolton reviewed Apr 1, 2025

View reviewed changes

Comment thread doc/configuration.md Outdated

Comment thread src/lib/common/Settings.cpp Outdated

Comment thread src/lib/common/Settings.cpp Outdated

Comment thread src/lib/gui/Diagnostic.cpp Outdated

This comment was marked as outdated.

Sign in to view

nbolton force-pushed the windowsBetterSettings branch from 24cfc73 to f3d3784 Compare April 1, 2025 12:23

This comment was marked as outdated.

Sign in to view

sithlord48 force-pushed the windowsBetterSettings branch 2 times, most recently from eaf1d1a to 03b78b1 Compare April 1, 2025 13:32

sithlord48 requested a review from nbolton April 1, 2025 13:34

This was referenced Apr 1, 2025

Upgrading to 1.21.1.0 breaks configuration, refuses to use correct config file #8434

Closed

Portable windows build #8431

Merged

sithlord48 added the 🩹 fix This PR fixes a reported bug label Apr 1, 2025

nbolton approved these changes Apr 2, 2025

View reviewed changes

sithlord48 added 6 commits April 2, 2025 11:34

refactor: allow proxy to load from registry if no file is provided

89a3b75

refactor: settings for windows try to use registry unless portable in…

4585543

…stall new Settings::isUsingRegistry() true when using the registry move daemon log back to config dir

refactor: Set default process Mode based on Settings type if we are I…

2cd532b

…NI Type we in desktop mode if Native (only on windows) we default to Service

refactor: Settings set default elevateMode based on settings type, fo…

557027a

…r registry we use Always, ini mode uses Never

refactor: SettingsDialog, Hide the service if its not able to be enabled

6cf95fe

feature: make sure when portable settings are cleared a new blank fil…

fdcbe83

…e is created

nbolton force-pushed the windowsBetterSettings branch from 03b78b1 to fdcbe83 Compare April 2, 2025 10:34

nbolton merged commit 46c6275 into master Apr 2, 2025

nbolton deleted the windowsBetterSettings branch April 2, 2025 11:39

Navigation Menu

Uh oh!

refactor: settings for windows - #8428

refactor: settings for windows #8428
nbolton merged 6 commits into
masterfrom
windowsBetterSettings

sithlord48 commented Mar 31, 2025 •

edited

Loading

Uh oh!

This comment was marked as resolved.

sithlord48 commented Apr 1, 2025 •

edited

Loading

Uh oh!

robot3498712 commented Apr 1, 2025

Uh oh!

sithlord48 commented Apr 1, 2025

Uh oh!

nbolton left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nbolton left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sithlord48 commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

sithlord48 commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robot3498712 commented Apr 1, 2025

Uh oh!

sithlord48 commented Apr 1, 2025

Uh oh!

nbolton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nbolton left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sithlord48 commented Mar 31, 2025 •

edited

Loading

sithlord48 commented Apr 1, 2025 •

edited

Loading

nbolton left a comment •

edited

Loading