fix: Handle empty layout names and language codes in layout parser - #8405
Merged
Conversation
nbolton
force-pushed
the
no-convert-empty-codes
branch
from
March 27, 2025 13:17
3810961 to
011f90c
Compare
nbolton
marked this pull request as ready for review
March 27, 2025 13:18
nbolton
enabled auto-merge (rebase)
March 27, 2025 13:18
sithlord48
approved these changes
Mar 27, 2025
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7814
The layout parser was trying to convert empty chars and generating a bunch of warnings. It's possibly related to #8076 but maybe not as both my keyboard layouts match.